Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Progressive Image Loading #1958

Open
2 of 8 tasks
revanth0212 opened this issue Nov 4, 2019 · 5 comments
Open
2 of 8 tasks

Implement Progressive Image Loading #1958

revanth0212 opened this issue Nov 4, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request help wanted Eligible for community contribution. performance Things related to perf Progress: ready for grooming

Comments

@revanth0212
Copy link
Contributor

revanth0212 commented Nov 4, 2019

Is your feature request related to a problem? Please describe.
Images in the gallery page only have 2 states, load full image or don't load at all.

image

Describe the solution you'd like
Load images progressively.

image

  1. UI Requests image.
  2. Service Worker intercepts the image request. If the image is present in the cache or a better image is present in the cache, return it.
  3. If there is a low res version of it is available in the cache, return it and fetch a high res version in the background. Once it is returned by the server, send a message to the UI component to update to get the new version.
  4. If no version of this image is present in the cache, fetch and return ultra low res version and also fetch high res version. Once the high res is available, send a message to the UI component to update.

Describe alternatives you've considered
Doing the same on UI but this puts a load on the main thread.

Additional context
This is similar to what Medium does. The important word is similar, not the same.

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@revanth0212 revanth0212 added enhancement New feature or request performance Things related to perf labels Nov 4, 2019
@awilcoxa awilcoxa added the help wanted Eligible for community contribution. label Jan 21, 2020
@awilcoxa
Copy link

awilcoxa commented Feb 3, 2020

Should also account for offline image, see previous issue: #493

@awilcoxa
Copy link

awilcoxa commented Mar 3, 2020

@revanth0212 to clarify scope of issue, is this specific to only progressive image loading?

@awilcoxa
Copy link

Marked as P3S3

@sirugh
Copy link
Contributor

sirugh commented Feb 23, 2021

@magento export issue to JIRA project PWA as Story

@github-jira-sync-bot
Copy link

✅ Jira issue (https://jira.corp.magento.com/browse/PWA-1472) is successfully created for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Eligible for community contribution. performance Things related to perf Progress: ready for grooming
Projects
None yet
Development

No branches or pull requests

4 participants