Fix Wrong Exception on Cli run when Command Not found #40063

Genaker · 2025-07-10T15:55:40Z

Before Fix error on Cli run:

After :

Description (*)

If you have ever tried to run bin/magento and been greeted with the maddening: "There is no command found in the namespace"

you already know how opaque Magento (Adobe Commerce) can be when a single CLI command class is broken. One constructor typo, a missing dependency, or a bad module upgrade and—boom—the whole console goes dark. No stack-trace, no filename, no clue. You are left spelunking through logs or disabling modules by trial and error. More than 10 years Adobe is not able to fix this critical issue! I'm tired and submitted the PR.

What My PR tiny but vital quality-of-life improvement:

Catches the original exception thrown while Magento is assembling its command list.
Prints the real message and class name before the fallback “no command found” notice.
The change is only a few lines, but the impact is huge: you immediately see which command class failed and why, so you can fix the root cause in minutes instead of hours.

Why every extension author & integrator should care:

Faster CI/CD – Broken modules fail loudly during automated builds; no more silent time-outs.
Happier merchants – Support teams pinpoint faulty third-party code instead of asking store owners for full backups.
Lean core – The patch touches only CLI bootstrap code; zero risk to storefront performance.

Thanks for backing real-world developer experience improvements—your click today could save countless debugging hundreds hours tomorrow!

Fixes #40006

Related Issue

m2-assistant · 2025-07-10T15:55:44Z

Hi @Genaker. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

ihor-sviziev · 2025-07-17T08:48:25Z

Just wonder if we can do a bit different approach - throw different type of exception when the command not found, and handle it differently. What do you think?

Copilot

Pull Request Overview

This PR improves error handling in the Magento CLI system when commands fail to initialize, providing developers with more detailed exception information instead of the generic "no commands defined in namespace" error. The change enhances debugging experience by showing the actual root cause when command classes are broken due to missing dependencies, constructor errors, or other issues.

Adds exception tracking for command initialization failures
Implements clearer error messaging that shows the original exception details
Moves setup command initialization to occur before other commands for better error isolation

Copilot · 2025-07-17T08:49:16Z

lib/internal/Magento/Framework/Console/Cli.php

+     * GetCommands exception.
+     * 


The docblock comment 'GetCommands exception' should be more descriptive. Consider: 'Exception thrown during command list initialization.'

Suggested change

* GetCommands exception.

*

* Exception thrown during command list initialization.

*

Copilot · 2025-07-17T08:49:17Z

lib/internal/Magento/Framework/Console/Cli.php

+                $combinedErrorMessage = "Exception during console commands initialization: " . 
+                    $this->getCommandsException->getMessage() . PHP_EOL; 


[nitpick] The string concatenation spans multiple lines unnecessarily. Consider combining into a single line or using sprintf for better readability: sprintf('Exception during console commands initialization: %s%s', $this->getCommandsException->getMessage(), PHP_EOL)

Suggested change

$combinedErrorMessage = "Exception during console commands initialization: " .

$this->getCommandsException->getMessage() . PHP_EOL;

$combinedErrorMessage = sprintf(

'Exception during console commands initialization: %s%s',

$this->getCommandsException->getMessage(),

PHP_EOL

);

Copilot · 2025-07-17T08:49:17Z

lib/internal/Magento/Framework/Console/Cli.php

+            if (class_exists(\Magento\Setup\Console\CommandList::class)) {
+                $setupCommandList = new \Magento\Setup\Console\CommandList($this->serviceManager);
+                $commands = array_merge($commands, $setupCommandList->getCommands());
+            }
+
            if ($this->objectManager->get(DeploymentConfig::class)->isAvailable()) {


The setup command initialization has been moved outside the deployment config check, which changes the execution order. This should be documented or the reasoning should be clearer, as it may affect command availability in different deployment states.

Suggested change

if (class_exists(\Magento\Setup\Console\CommandList::class)) {

$setupCommandList = new \Magento\Setup\Console\CommandList($this->serviceManager);

$commands = array_merge($commands, $setupCommandList->getCommands());

}

if ($this->objectManager->get(DeploymentConfig::class)->isAvailable()) {

if ($this->objectManager->get(DeploymentConfig::class)->isAvailable()) {

if (class_exists(\Magento\Setup\Console\CommandList::class)) {

$setupCommandList = new \Magento\Setup\Console\CommandList($this->serviceManager);

$commands = array_merge($commands, $setupCommandList->getCommands());

}

ihor-sviziev · 2025-07-17T08:51:55Z

lib/internal/Magento/Framework/Console/Cli.php

+            if (class_exists(\Magento\Setup\Console\CommandList::class)) {
+                $setupCommandList = new \Magento\Setup\Console\CommandList($this->serviceManager);
+                $commands = array_merge($commands, $setupCommandList->getCommands());
+            }


Could you please explain, why this change is needed?

From reply in #40063 (comment):

We don't need these lines; it is probably due to a merge issue. You can
follow the logic. These lines don't change logic, just were touched by the
commit

These lines were added, so let's remove them if we don't need them

Genaker · 2025-07-17T08:59:32Z

We don't need these lines; it is probably due to a merge issue. You can follow the logic. These lines don't change logic, just were touched by the commit

…

On Thu, Jul 17, 2025 at 1:52 AM Ihor Sviziev ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In lib/internal/Magento/Framework/Console/Cli.php <#40063 (comment)>: > + if (class_exists(\Magento\Setup\Console\CommandList::class)) { + $setupCommandList = new \Magento\Setup\Console\CommandList($this->serviceManager); + $commands = array_merge($commands, $setupCommandList->getCommands()); + } Could you please explain, why this change is needed? — Reply to this email directly, view it on GitHub <#40063 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACGJNZRP4HH4GAEE6SC2L5L3I5P4JAVCNFSM6AAAAACBHOAE7KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTAMRYGU3TQMJUGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Genaker · 2025-07-17T09:48:02Z

You can. The main issue is that we need to show which command failed, not just the command that was not found. The best solution could be to allow the execution of other commands and skip the command with an error.

…

On Thu, Jul 17, 2025 at 1:48 AM Ihor Sviziev ***@***.***> wrote: *ihor-sviziev* left a comment (magento/magento2#40063) <#40063 (comment)> Just wonder if we can do a bit different approach - throw different type of exception when the command not found, and handle it differently. What do you think? — Reply to this email directly, view it on GitHub <#40063 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACGJNZVFDFNLAFOKNSXD4D33I5PO5AVCNFSM6AAAAACBHOAE7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAOBTGIYDGMZVGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ihor-sviziev

Hi,
I've tried to debug a bit, and feels like the issue is coming from the masking original exception - if exception happened during loading list of the commands - we're just skipping it and trying to print the failure message after, but command is trying to be executed.
Ref:

magento2/lib/internal/Magento/Framework/Console/Cli.php

Lines 150 to 169 in 16c2c4a

    
           protected function getApplicationCommands() 
        
           { 
        
               $commands = []; 
        
               try { 
        
                   if ($this->objectManager->get(DeploymentConfig::class)->isAvailable()) { 
        
                       /** @var CommandListInterface */ 
        
                       $commandList = $this->objectManager->create(CommandListInterface::class); 
        
                       $commands = array_merge($commands, $commandList->getCommands()); 
        
                   } 
        
                   $commands = array_merge( 
        
                       $commands, 
        
                       $this->getVendorCommands($this->objectManager) 
        
                   ); 
        
               } catch (\Exception $e) { 
        
                   $this->initException = $e; 
        
               } 
        
               return $commands; 
        
           }

This code was introduced long time ago in 293ba1e

I think this logic has to be changed - we should not hide the exception, but print it directly when it happens - just remove try-catch in the getApplicationCommands method.

This will result in having a clear exception at the beginning:

$ php bin/magento -vvv

In ClassReader.php line 34:
                                                                  
  [ReflectionException (-1)]                                      
  Class "Test\TEsctCli\Console\Command\TestWrong" does not exist  
                                                                  

Exception trace:
  at /var/www/html/vendor/magento/framework/Code/Reader/ClassReader.php:34
 ReflectionClass->__construct() at /var/www/html/vendor/magento/framework/Code/Reader/ClassReader.php:34
 Magento\Framework\Code\Reader\ClassReader->getConstructor() at /var/www/html/vendor/magento/framework/ObjectManager/Definition/Runtime.php:50
 Magento\Framework\ObjectManager\Definition\Runtime->getParameters() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:48
 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() at /var/www/html/vendor/magento/framework/ObjectManager/ObjectManager.php:73
 Magento\Framework\ObjectManager\ObjectManager->get() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:206
 Magento\Framework\ObjectManager\Factory\AbstractFactory->parseArray() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:182
 Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:276
 Magento\Framework\ObjectManager\Factory\AbstractFactory->getResolvedArgument() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/AbstractFactory.php:239
 Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:34
 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments() at /var/www/html/vendor/magento/framework/ObjectManager/Factory/Dynamic/Developer.php:59
 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() at /var/www/html/vendor/magento/framework/ObjectManager/ObjectManager.php:59
 Magento\Framework\ObjectManager\ObjectManager->create() at /var/www/html/vendor/magento/framework/Console/Cli.php:156
 Magento\Framework\Console\Cli->getApplicationCommands() at /var/www/html/vendor/magento/framework/Console/Cli.php:137
 Magento\Framework\Console\Cli->getDefaultCommands() at /var/www/html/vendor/symfony/console/Application.php:1327
 Symfony\Component\Console\Application->init() at /var/www/html/vendor/symfony/console/Application.php:692
 Symfony\Component\Console\Application->find() at /var/www/html/vendor/symfony/console/Application.php:266
 Symfony\Component\Console\Application->doRun() at /var/www/html/vendor/magento/framework/Console/Cli.php:118
 Magento\Framework\Console\Cli->doRun() at /var/www/html/vendor/symfony/console/Application.php:175
 Symfony\Component\Console\Application->run() at /var/www/html/bin/magento:23

What do you think about it?

Genaker · 2025-07-17T18:33:22Z

I've tried to debug a bit, and feels like the issue is coming from the masking original exception - if exception happened during loading list of the commands - we're just skipping it and trying to print the failure message after, but command is trying to be executed.
Ref:

Correct this approach works also but i would like to have more descriptive message to tell user something wrong not just default exception. For example check you extension not just : ReflectionException. Even we can check if it is file exist but has error, or it is file doesn't exist but in di.xml/ also we can show/log exception and continue or original command execution. Because after this you can't even cache clear you need do this manually.

Fix Wrong Exception on Cli run when Command Not found

f89b8ba

Genaker mentioned this pull request Jul 10, 2025

Ensure that a single command failure logs the error (file or stderr) without stopping the execution of subsequent CLI commands. #40006

Open

ihor-sviziev requested a review from Copilot July 17, 2025 08:48

ct-prd-projects-boards-automation bot added the Progress: review label Jul 17, 2025

Copilot AI reviewed Jul 17, 2025

View reviewed changes

ihor-sviziev linked an issue Jul 17, 2025 that may be closed by this pull request

Ensure that a single command failure logs the error (file or stderr) without stopping the execution of subsequent CLI commands. #40006

Open

ihor-sviziev self-assigned this Jul 17, 2025

ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 17, 2025

ct-prd-projects-boards-automation bot added this to Pull Requests Dashboard Jul 17, 2025

github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 17, 2025

ct-prd-projects-boards-automation bot added the Progress: pending review label Jul 17, 2025

ihor-sviziev reviewed Jul 17, 2025

View reviewed changes

ihor-sviziev requested changes Jul 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Wrong Exception on Cli run when Command Not found #40063

Fix Wrong Exception on Cli run when Command Not found #40063

Uh oh!

Genaker commented Jul 10, 2025 •

edited by ihor-sviziev

Loading

Uh oh!

m2-assistant bot commented Jul 10, 2025

Uh oh!

ihor-sviziev commented Jul 17, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

Copilot AI Jul 17, 2025

Uh oh!

ihor-sviziev Jul 17, 2025

Uh oh!

ihor-sviziev Jul 17, 2025 •

edited

Loading

Uh oh!

Genaker commented Jul 17, 2025 via email

Uh oh!

Genaker commented Jul 17, 2025 via email

Uh oh!

ihor-sviziev left a comment •

edited

Loading

Uh oh!

Genaker commented Jul 17, 2025

Uh oh!

Uh oh!

		$combinedErrorMessage = "Exception during console commands initialization: " .
		$this->getCommandsException->getMessage() . PHP_EOL;

-                $combinedErrorMessage = "Exception during console commands initialization: " .
-                    $this->getCommandsException->getMessage() . PHP_EOL;
+                $combinedErrorMessage = sprintf(
+                    'Exception during console commands initialization: %s%s',
+                    $this->getCommandsException->getMessage(),
+                    PHP_EOL
+                );

	protected function getApplicationCommands()
	{
	$commands = [];
	try {
	if ($this->objectManager->get(DeploymentConfig::class)->isAvailable()) {
	/** @var CommandListInterface */
	$commandList = $this->objectManager->create(CommandListInterface::class);
	$commands = array_merge($commands, $commandList->getCommands());
	}

	$commands = array_merge(
	$commands,
	$this->getVendorCommands($this->objectManager)
	);
	} catch (\Exception $e) {
	$this->initException = $e;
	}

	return $commands;
	}

Fix Wrong Exception on Cli run when Command Not found #40063

Are you sure you want to change the base?

Fix Wrong Exception on Cli run when Command Not found #40063

Uh oh!

Conversation

Genaker commented Jul 10, 2025 • edited by ihor-sviziev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Issue

Uh oh!

m2-assistant bot commented Jul 10, 2025

Uh oh!

ihor-sviziev commented Jul 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Jul 17, 2025

Choose a reason for hiding this comment

Uh oh!

ihor-sviziev Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Genaker commented Jul 17, 2025 via email

Uh oh!

Genaker commented Jul 17, 2025 via email

Uh oh!

ihor-sviziev left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Genaker commented Jul 17, 2025

Uh oh!

Uh oh!

Genaker commented Jul 10, 2025 •

edited by ihor-sviziev

Loading

ihor-sviziev Jul 17, 2025 •

edited

Loading

ihor-sviziev left a comment •

edited

Loading