-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Remove sprintf usage in phrase calls #40033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Remove sprintf usage in phrase calls #40033
Conversation
Hi @thomas-kl1. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento create issue |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @thomas-kl1,
Thanks for the contribution!
PR changes looks good to us, but please check the static test failure.
Thanks
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @thomas-kl1,
Thanks for making the changes!
The failed test seems flaky to us, approving the PR for further processing.
Thanks
@magento run Functional Tests CE |
Description (*)
Remove the usage of sprintf in the phrase function call in the Magento core.
Using sprintf to interpolate variable in the phrase prevent the phrase to be localized by said function.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
It exists other cases in Magento packages, but some are closed to public contribution.
Contribution checklist (*)
Resolved issues: