Skip to content

Remove sprintf usage in phrase calls #40033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

thomas-kl1
Copy link
Member

@thomas-kl1 thomas-kl1 commented Jul 1, 2025

Description (*)

Remove the usage of sprintf in the phrase function call in the Magento core.
Using sprintf to interpolate variable in the phrase prevent the phrase to be localized by said function.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

It exists other cases in Magento packages, but some are closed to public contribution.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Remove sprintf usage in phrase calls #40050: Remove sprintf usage in phrase calls

Copy link

m2-assistant bot commented Jul 1, 2025

Hi @thomas-kl1. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@thomas-kl1
Copy link
Member Author

@magento run all tests

@engcom-Charlie
Copy link
Contributor

@magento create issue

@engcom-Charlie engcom-Charlie added the Priority: P3 May be fixed according to the position in the backlog. label Jul 8, 2025
@github-project-automation github-project-automation bot moved this to Pending Review in Pull Requests Dashboard Jul 8, 2025
@engcom-Charlie engcom-Charlie added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community and removed Priority: P3 May be fixed according to the position in the backlog. labels Jul 9, 2025
@engcom-Hotel
Copy link
Contributor

@magento run all tests

@thomas-kl1
Copy link
Member Author

@magento run all tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thomas-kl1,

Thanks for the contribution!

PR changes looks good to us, but please check the static test failure.

Thanks

@engcom-Hotel engcom-Hotel moved this from Pending Review to Changes Requested in Community Dashboard Jul 16, 2025
@thomas-kl1
Copy link
Member Author

@magento run all tests

@engcom-Hotel engcom-Hotel moved this from Changes Requested to Review in Progress in Community Dashboard Jul 17, 2025
Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thomas-kl1,

Thanks for making the changes!

The failed test seems flaky to us, approving the PR for further processing.

Thanks

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 17, 2025
@engcom-Dash engcom-Dash self-assigned this Jul 17, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Testing to Testing in Progress in Community Dashboard Jul 17, 2025
@engcom-Dash
Copy link
Contributor

✔️ QA Passed

No manual testing required for the changes. This PR improves the code and also removed sprintf() usage from the phrase. sprintf() inside phrase can cause the localization issue. we use %1, %2, etc. inside __() for placeholders. This ensures proper translation and localization support.

The build is green hence moving this PR in Merge In Progress.

Screenshot 2025-07-18 at 2 01 47 PM

@engcom-Dash engcom-Dash moved this from Testing in Progress to Merge in Progress in Community Dashboard Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Status: Merge in Progress
Development

Successfully merging this pull request may close these issues.

[Issue] Remove sprintf usage in phrase calls
5 participants