GraphQL newsletter uses wrong user id

[bartlubbersen]

Preconditions and environment

• Magento 2.4.7-p3
• GraphQL request for newsletter needs to contain a valid authorization token with user type that is not customer.

Steps to reproduce

1. Create a valid integration token with user type 1 (integration)
2. Do a GraphQL request to subscribe to a newsletter with in the authorization header this token

Expected result

The email should be subscribed to the newsletter since the authorization header doesn't belong to a customer the customer should not be validated.

Actual result

The GraphQL api returns an error that it could not retrieve the customer. This is because the \Magento\NewsletterGraphQl\Model\Resolver\SubscribeEmailToNewsletter class does retrieve the user id from the context, but does not validate the user type.

It then tries to retrieve the customer by id based on the integration ID. Which will result in a non existing customer error if a customer with the same id as the integration token does not exist..

Additional information

In the image you can see the user_type is 1 and not 3 which you would expect for a customer. But you can also see it still uses the id as if it was a customer id.

Workaround for now would be to not send an authorization header, but sometimes the system will send them by default so Magento should still work correctly even with the header.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @bartlubbersen. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @bartlubbersen,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

The email was subscribed to the newsletter successfully.

Could you please try to reproduce the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[engcom-Bravo]

Hi @bartlubbersen,

This issue is being closed since it has not been updated in a long time.Please feel free to reopen or raise a new ticket if the issue still exists.

Thanks.