Special Price To Date is wrongly validated on applySpecialPrice

[tcoluke]

Preconditions and environment

• Actually reproduced on Magento 2.4.4-p7 but nothing is changed in recent version

Steps to reproduce

Use Rest API to set special price
/rest/default/V1/products/special-price

provide body like

{
  "prices": [
    {
      "price": 5,
      "store_id": 1,
      "sku": "1181",
      "price_from": "2024-08-02 17:00:00",
      "price_to": "2024-09-12 17:00:00",
      "extension_attributes": {}
    }
  ]
}

then check your price on front-end
admin or whatever

your special price will be visible until tomorrow 17

so instead expire at 2024-09-12 17:00:00 it will expire on 2024-09-13 17:00:00

because of validation on Magento\Catalog\Model\Product\Type\Price::calculateSpecialPrice

            if ($this->_localeDate->isScopeDateInInterval($store, $specialPriceFrom, $specialPriceTo)) {
                $finalPrice = min($finalPrice, (float) $specialPrice);
            }

instead of check in range from -> to
it add to end date 1 day

Magento\Framework\Stdlib\DateTime\Timezone::isScopeDateInInterval

maybe it can be used for other validation but for real not for calculateSpecialPrice it should be in range from -> to set by admin

Expected result

Product special price should expire on date set by admin or 3rd party system by REST API

Actual result

End date is missed and expire day after

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @tcoluke. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[tcoluke]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[tcoluke]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[tcoluke]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[tcoluke]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @tcoluke. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @tcoluke, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[tcoluke]

@engcom-Bravo are you working on it ? and can you also investigate why I can't get magento instance ?