Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig #39165

Open
3 of 5 tasks
m2-assistant bot opened this issue Sep 12, 2024 · 2 comments · May be fixed by #39163
Open
3 of 5 tasks
Assignees
Labels
feature request Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Sep 12, 2024

This issue is automatically created based on existing pull request: #39163: [Feature request] Add paypal_express_visible_on_cart & paypal_express_active in graphql StoreConfig


Description (*)

This PR add paypal_express_visible_on_cart and paypal_express_active in graphQl StoreConfig type.

👍 I think, is important to prefix configuration by theme (ie: paypal) - So payment_payflowpro_cc_vault_active must be replaced by paypal_payment_payflowpro_cc_vault_active ...

query StoreConfig {
  storeConfig {
    paypal_express_active
    paypal_express_visible_on_cart
  }
}

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PayPal and execute following graphql query :

query StoreConfig {
  storeConfig {
    paypal_express_active
    paypal_express_visible_on_cart
  }
}

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
Copy link
Author

m2-assistant bot commented Sep 12, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Sep 12, 2024
@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 12, 2024
@engcom-Bravo
Copy link
Contributor

Hi @dimitriBouteille,

Thanks for your reporting and collaboration.

We have verified and it seems to be an improvement.Hence we are considering this as Feature Request.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Status: No status
1 participant