Bump version

Author: magec

Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "utf8mb4rails"
+require 'bundler/setup'
+require 'utf8mb4rails'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "utf8mb4rails"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

lib/utf8mb4rails.rb

@@ -14,14 +14,16 @@ def usage
   puts 'You can also specify the COLLATION (utf8mb4_unicode_520_ci)'
 end
 
+# Top Module
 module Utf8mb4rails
   extend Rake::DSL
 
   namespace :db do
     desc 'migrates a table[/column] (TABLE, COLUMN env vars) to utf8mb encoding'
     task utf8mb4: :environment do
       require 'departure'
-      Departure.configure do |_config|; end
+      Departure.configure do |_config|
+      end
 
       table = ENV['TABLE']
       unless table

lib/utf8mb4rails/migrator/column_info.rb

@@ -5,7 +5,7 @@ module Migrator
     # received from the database
     class ColumnInfo
       TEXT_TYPES = %w(CHAR VARCHAR TINYTEXT TEXT MEDIUMTEXT LONGTEXT).freeze
-      attr_accessor :info
+      attr_reader :info
 
       # Receives a hash with (:type, :default, :max_length, :charset)
       def initialize(info)
@@ -19,14 +19,18 @@ def utf8mb4?
 
       # @return String : the sql part of the new type of the column definition
       def new_type_for_sql
-        return "#{info[:type]}(#{info[:max_length]})" if info[:type] =~ /CHAR/
-        info[:type]
+        info_type = info[:type]
+        return "#{info_type}(#{info[:max_length]})" if info_type =~ /CHAR/
+
+        info_type
       end
 
       # @return String : the sql part of the default value of the column definition
       def default_value_for_sql
-        return nil unless info[:default]
-        "default '#{info[:default]}'"
+        info_default = info[:default]
+        return nil unless info_default
+
+        "default '#{info_default}'"
       end
 
       # @return Bool : True if the column is of a text type

lib/utf8mb4rails/migrator/db_inspector.rb

@@ -1,7 +1,9 @@
 module Utf8mb4rails
   module Migrator
+    # DB introspection (only for columns)
     class DBInspector
       # Initializes AR
+      # :reek:UtilityFunction
       def initialize
         ActiveRecord::Base.establish_connection(
           ActiveRecord::Base.connection_config.merge(adapter: 'percona')
@@ -10,6 +12,7 @@ def initialize
 
       ##
       # @returns [Array<String>] An array with column names
+      # :reek:UtilityFunction
       def columns(table)
         ActiveRecord::Base.connection.columns(table).map(&:name)
       end
@@ -20,6 +23,7 @@ def columns(table)
       # @param [String] column
       #
       # @returns [Hash] { type: String, default: String or nil, charset: String or nil }
+      # :reek:FeatureEnvy
       def column_info(table, column)
         sql = "SELECT DATA_TYPE, COLUMN_DEFAULT, CHARACTER_SET_NAME, CHARACTER_MAXIMUM_LENGTH
         FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = '#{table}'
@@ -36,6 +40,7 @@ def column_info(table, column)
 
       private
 
+      # :reek:UtilityFunction
       def database_name
         ActiveRecord::Base.connection.current_database
       end

lib/utf8mb4rails/migrator/runner.rb

@@ -1,14 +1,19 @@
+require 'English'
+
 module Utf8mb4rails
   module Migrator
+    # This class will perform the actual migration, will run sql queries that
+    # alters tables
     class Runner
       NEW_COLLATION = ENV.fetch('COLLATION', 'utf8mb4_unicode_520_ci').freeze
 
-      attr_accessor :inspector
+      attr_reader :inspector
 
       def initialize
         @inspector = DBInspector.new
       end
 
+      # :reek:FeatureEnvy
       def migrate_column!(table, column)
         column_info = inspector.column_info(table, column)
         if column_info.utf8mb4?
@@ -22,22 +27,31 @@ def migrate_column!(table, column)
         ActiveRecord::Base.connection.execute(sql)
       end
 
-      def migrate_table_schema!(table)
-        sql = "ALTER TABLE `#{table}` CONVERT TO CHARACTER SET utf8mb4 COLLATE #{NEW_COLLATION}"
-        ActiveRecord::Base.connection.execute(sql)
-      end
-
       def migrate_table!(table)
+        sql = []
         inspector.columns(table).each do |column|
-          puts "      migrating #{table}:#{column}"
-          migrate_column!(table, column)
+          column_info = inspector.column_info(table, column)
+          next if column_info.utf8mb4? || !column_info.text_column? || skipped_column?(column)
+          sql << "DROP COLUMN \`#{column}`"
+          sql << "ADD COLUMN \`#{column}`\ #{column_info.new_type_for_sql} \
+CHARACTER SET utf8mb4 COLLATE #{NEW_COLLATION} #{column_info.default_value_for_sql}"
         end
-        migrate_table_schema!(table)
+        sql << "CONVERT TO CHARACTER SET utf8mb4 COLLATE #{NEW_COLLATION}"
+        ActiveRecord::Base.connection.execute("ALTER TABLE `#{table}` #{sql.join(' , ')};")
       rescue
         puts "Problems accesing the table #{table}"
-        puts $!
+        puts $ERROR_INFO
         exit 1
       end
+
+      private
+
+      # :reek:UtilityFunction
+      def skipped_column?(column_name)
+        return false unless ENV.key? 'SKIP_COLUMNS'
+        skipped_columns = ENV['SKIP_COLUMNS'].join(',')
+        skipped_columns.include(column_name)
+      end
     end
   end
 end

lib/utf8mb4rails/version.rb

@@ -1,3 +1,3 @@
 module Utf8mb4rails
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'.freeze
 end

utf8mb4rails.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'utf8mb4rails/version'
@@ -10,16 +11,19 @@ Gem::Specification.new do |spec|
   spec.email         = ['[email protected]']
 
   spec.summary       = 'Adds a task to migrate mysql utf8 tables to utf8mb4 (emojis)'
-  spec.description   = 'Poetry is so XIX century, nowadays we express ourselves using emojis. This gem adds a task to migrate mysql utf8 tables to utf8mb4 in rails projects.'
+  spec.description   = 'Poetry is so XIX century, nowadays we express ourselves using emojis.
+This gem adds a task to migrate mysql utf8 tables to utf8mb4 in rails projects.'
   spec.homepage      = 'https://github.com/magec/utf8mb4rails'
   spec.license       = 'MIT'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+    f.match(%r{^(test|spec|features)/})
+  end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'departure', '~> 4.0', '>= 4.0.1'
+  spec.add_runtime_dependency 'departure', '~> 6.0'
   spec.add_runtime_dependency 'mysql2', '~> 0.4.0'
 
   spec.add_development_dependency 'bundler', '~> 1.12'