Refactor preset initialization and improve wt.exe support

---
- 🛠️ Refactored default preset initialization to use lazy-loading with a private backing field and InitializePresets method.
- 🗂️ Moved preset setup logic out of LoadSettingsFromStorage for better organization and reliability.
- 🧩 Improved detection and handling of the GitHub Console preset using safer environment variable access.
- 🪟 Updated process launch logic to set UseShellExecute for Windows Terminal (wt.exe/wt) and only modify PATH when appropriate.
- 📝 Updated "Windows Terminal" preset to use "wt.exe" and proper directory argument for improved compatibility.
Fixes #91
Fixes #100

Author: madskristensen

src/OpenCommandLine/CommandLineLauncher.cs

@@ -19,14 +19,22 @@ public static void StartProcess(string workingDirectory, string command, string
                 command = Environment.ExpandEnvironmentVariables(command ?? string.Empty);
                 arguments = Environment.ExpandEnvironmentVariables(arguments ?? string.Empty);
 
+                // Windows Terminal (wt.exe) is a modern Windows app that requires shell execution
+                bool useShellExecute = command.IndexOf("wt.exe", StringComparison.OrdinalIgnoreCase) >= 0 ||
+                                       command.IndexOf("wt", StringComparison.OrdinalIgnoreCase) >= 0 && 
+                                       !command.EndsWith(".exe", StringComparison.OrdinalIgnoreCase);
+
                 var start = new ProcessStartInfo(command, arguments)
                 {
                     WorkingDirectory = workingDirectory,
                     LoadUserProfile = true,
-                    UseShellExecute = false
+                    UseShellExecute = useShellExecute
                 };
 
-                ModifyPathVariable(start);
+                if (!useShellExecute)
+                {
+                    ModifyPathVariable(start);
+                }
 
                 using (Process.Start(start))
                 {

src/OpenCommandLine/Options.cs

@@ -1,4 +1,4 @@
-using Microsoft.VisualStudio.Shell;
+using Microsoft.VisualStudio.Shell;
 using System;
 using System.Collections.Generic;
 using System.ComponentModel;
@@ -8,10 +8,52 @@ namespace MadsKristensen.OpenCommandLine
 {
     internal class Options : DialogPage
     {
-        public static Dictionary<string, Command> DefaultPresets = new Dictionary<string, Command>();
+        private static Dictionary<string, Command> _defaultPresets;
         private bool _isLoading, _isChanging;
         private string _preset;
 
+        public static Dictionary<string, Command> DefaultPresets
+        {
+            get
+            {
+                if (_defaultPresets == null)
+                {
+                    InitializePresets();
+                }
+                return _defaultPresets;
+            }
+        }
+
+        private static void InitializePresets()
+        {
+            _defaultPresets = new Dictionary<string, Command>();
+
+            string installDir = VsHelpers.GetInstallDirectory();
+            string devPromptFile = installDir != null 
+                ? Path.Combine(installDir, @"..\Tools\VsDevCmd.bat") 
+                : "";
+
+            _defaultPresets["cmd"] = new Command("cmd.exe");
+            _defaultPresets["Dev Cmd Prompt"] = new Command("cmd.exe", "/k \"" + devPromptFile + "\"");
+            _defaultPresets["PowerShellCore"] = new Command("pwsh.exe", "-ExecutionPolicy Bypass -NoExit");
+            _defaultPresets["PowerShell"] = new Command("powershell.exe", "-ExecutionPolicy Bypass -NoExit");
+            _defaultPresets["PowerShell ISE"] = new Command("powershell_ise.exe");
+            _defaultPresets["posh-git"] = new Command("powershell.exe", @"-ExecutionPolicy Bypass -NoExit -Command .(Resolve-Path ""$env:LOCALAPPDATA\GitHub\shell.ps1""); .(Resolve-Path ""$env:github_posh_git\profile.example.ps1"")");
+            _defaultPresets["Git Bash"] = new Command(@"C:\Program Files\Git\git-bash.exe");
+            _defaultPresets["Babun"] = new Command(@"%UserProfile%\.babun\cygwin\bin\mintty.exe", "/bin/env CHERE_INVOKING=1 /bin/zsh.exe");
+
+            string GitHubForWindowsPath = Path.Combine(Environment.GetEnvironmentVariable("LocalAppData") ?? "", "GitHub", "GitHub.appref-ms");
+            if (File.Exists(GitHubForWindowsPath))
+            {
+                _defaultPresets["GitHub Console"] = new Command(@"%LOCALAPPDATA%\GitHub\GitHub.appref-ms", "-open-shell");
+            }
+
+            _defaultPresets["cmder"] = new Command("cmder.exe", "/START \"%folder%\"");
+            _defaultPresets["ConEmu"] = new Command("ConEmu64.exe", "/cmd PowerShell.exe");
+            _defaultPresets["Windows Terminal"] = new Command("wt.exe", "-d \"%folder%\"");
+            _defaultPresets["Custom"] = new Command(string.Empty, string.Empty);
+        }
+
         [Category("Command Preset")]
         [DisplayName("Select preset")]
         [Description("Select one of the predefined command configurations")]
@@ -114,32 +156,6 @@ public override void LoadSettingsFromStorage()
                 Preset = "cmd";
             }
 
-            if (DefaultPresets.Count == 0)
-            {
-                string installDir = VsHelpers.GetInstallDirectory();
-                string devPromptFile = Path.Combine(installDir, @"..\Tools\VsDevCmd.bat");
-
-                DefaultPresets["cmd"] = new Command("cmd.exe");
-                DefaultPresets["Dev Cmd Prompt"] = new Command("cmd.exe", "/k \"" + devPromptFile + "\"");
-                DefaultPresets["PowerShellCore"] = new Command("pwsh.exe", "-ExecutionPolicy Bypass -NoExit");
-                DefaultPresets["PowerShell"] = new Command("powershell.exe", "-ExecutionPolicy Bypass -NoExit");
-                DefaultPresets["PowerShell ISE"] = new Command("powershell_ise.exe");
-                DefaultPresets["posh-git"] = new Command("powershell.exe", @"-ExecutionPolicy Bypass -NoExit -Command .(Resolve-Path ""$env:LOCALAPPDATA\GitHub\shell.ps1""); .(Resolve-Path ""$env:github_posh_git\profile.example.ps1"")");
-                DefaultPresets["Git Bash"] = new Command(@"C:\Program Files\Git\git-bash.exe");
-                DefaultPresets["Babun"] = new Command(@"%UserProfile%\.babun\cygwin\bin\mintty.exe", "/bin/env CHERE_INVOKING=1 /bin/zsh.exe");
-
-                string GitHubForWindowsPath = Path.Combine(Environment.GetEnvironmentVariable("LocalAppData"), "GitHub", "GitHub.appref-ms");
-                if (File.Exists(GitHubForWindowsPath))
-                {
-                    DefaultPresets["GitHub Console"] = new Command(@"%LOCALAPPDATA%\GitHub\GitHub.appref-ms", "-open-shell");
-                }
-
-                DefaultPresets["cmder"] = new Command("cmder.exe", "/START \"%folder%\"");
-                DefaultPresets["ConEmu"] = new Command("ConEmu64.exe", "/cmd PowerShell.exe");
-                DefaultPresets["Windows Terminal"] = new Command("wt", "-d %folder%");
-                DefaultPresets["Custom"] = new Command(string.Empty, string.Empty);
-            }
-
             _isLoading = false;
         }