refactor(bigchaindb): clippy

Author: macroexpansion

src/connection.rs

@@ -9,18 +9,18 @@ use crate::{
     transport::Transport,
 };
 
-const BLOCKS: &'static str = "blocks";
-const BLOCKS_DETAIL: &'static str = "blocks/%(blockHeight)s";
-const OUTPUTS: &'static str = "outputs";
-const TRANSACTIONS: &'static str = "transactions";
-const TRANSACTIONS_SYNC: &'static str = "transactions?mode=sync";
-const TRANSACTIONS_ASYNC: &'static str = "transactions?mode=async";
-const TRANSACTIONS_COMMIT: &'static str = "transactions?mode=commit";
-const TRANSACTIONS_DETAIL: &'static str = "transactions/{transaction_id}";
-const ASSETS: &'static str = "assets";
-const METADATA: &'static str = "metadata";
+const BLOCKS: &str = "blocks";
+const BLOCKS_DETAIL: &str = "blocks/%(blockHeight)s";
+const OUTPUTS: &str = "outputs";
+const TRANSACTIONS: &str = "transactions";
+const TRANSACTIONS_SYNC: &str = "transactions?mode=sync";
+const TRANSACTIONS_ASYNC: &str = "transactions?mode=async";
+const TRANSACTIONS_COMMIT: &str = "transactions?mode=commit";
+const TRANSACTIONS_DETAIL: &str = "transactions/{transaction_id}";
+const ASSETS: &str = "assets";
+const METADATA: &str = "metadata";
 
-const DEFAULT_NODE: &'static str = "http://localhost:9984/api/v1/";
+const DEFAULT_NODE: &str = "http://localhost:9984/api/v1/";
 const DEFAULT_TIMEOUT: u64 = 20; // default timeout is 20 seconds
 
 #[derive(Debug, Clone)]

src/lib.rs

@@ -9,12 +9,12 @@ pub mod json {
     pub use serde_json::*;
 }
 
-use bs58;
+
 use crypto_conditions::{fulfillment::Fulfillment, Ed25519Sha256};
 use rand::RngCore;
 use serde::{Deserialize, Serialize};
 use stable_sort::stable_sorted;
-use tweetnacl;
+
 
 pub fn randombytes(seed: &mut [u8; 32]) {
     let mut rng = rand::thread_rng();

src/main.rs

@@ -22,7 +22,7 @@ async fn test_post_transaction_commit() {
     let metadata = json!({"metadata": "rust"});
     let public_key = "6zaQbbRi7RCFhCF35tpVDu2nEfR9fZCqx2MvUa7pKRmX";
     let private_key = "CHwxsNPzRXTzCz25KZ9TJcBJ45H25JKkLL4HrX1nBfXT";
-    let condition = Transaction::make_ed25519_condition(&public_key, true).unwrap();
+    let condition = Transaction::make_ed25519_condition(public_key, true).unwrap();
     let output = Transaction::make_output(condition, String::from("1"));
     let transaction = Transaction::make_create_transaction(
         Some(assetdata),

src/request.rs

@@ -40,6 +40,12 @@ pub struct RequestOption<'a> {
     pub url_template: Option<UrlTemplateSpec<'a>>,
 }
 
+impl<'a> Default for RequestOption<'a> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<'a> RequestOption<'a> {
     pub fn new() -> Self {
         Self {
@@ -186,7 +192,7 @@ pub async fn base_request<T: DeserializeOwned>(
         let body = serde_json::to_string(
             &request_config
                 .json_body
-                .ok_or_else(|| Error::RequestNoBodyProvided)?,
+                .ok_or(Error::RequestNoBodyProvided)?,
         )
         .map_err(|_| Error::SerdeError)?;
 

src/transaction.rs

@@ -102,6 +102,12 @@ pub struct TransactionTemplate {
     pub version: String,
 }
 
+impl Default for TransactionTemplate {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl TransactionTemplate {
     pub fn new() -> Self {
         Self {
@@ -146,11 +152,7 @@ impl Transaction {
         outputs: Vec<Output>,
         issuers: Vec<String>,
     ) -> TransactionTemplate {
-        let asset = if let Some(asset) = asset {
-            Some(Asset::Definition(CreateAsset { data: asset }))
-        } else {
-            None
-        };
+        let asset = asset.map(|asset| Asset::Definition(CreateAsset { data: asset }));
         let inputs: Vec<InputTemplate> = issuers
             .iter()
             .map(|issuer| InputTemplate::new(vec![issuer.to_string()], None, None))
@@ -248,7 +250,7 @@ impl Transaction {
                         .get("transaction_id")
                         .expect("no transaction_id in json::Value")
                         .to_string()
-                        .replace("\"", ""); // remove double quotes around the string
+                        .replace('\"', ""); // remove double quotes around the string
                     let output_index = fulfills
                         .get("output_index")
                         .expect("no output_index in json::Value")