Skip to content

Commit 58e84dc

Browse files
committed
fix special ults not getting transferred because their skillID is not inside the lookup table
1 parent 8ecf12d commit 58e84dc

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
## 2025.08.24
2+
- fix the "missing icon" bug (the question mark) that was caused trying to send skillIDs that do not exist in the lookup table.
3+
14
## 2025.08.16
25
- add SkillLine sharing as an option
36
- fix a bug where the ult get sent if requested even though the local player has no addon using it

LibGroupCombatStats.lua

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ local SKILLLINES = "SKILLLINES"
4949

5050
local LGB = LibGroupBroadcast
5151
local EM = EVENT_MANAGER
52+
local SDM = SKILLS_DATA_MANAGER
5253
local LocalEM = ZO_CallbackObject:New()
5354
local strmatch = string.match
5455
local _isFirstOnPlayerActivated = true
@@ -809,6 +810,12 @@ function combat.GetBossTargetDamage()
809810
return bossUnits, totalBossDamage, bossTime
810811
end
811812

813+
---
814+
815+
local function GetBaseAbilityId(rawAbilityId)
816+
if rawAbilityId == nil or rawAbilityId == 0 then return 0 end
817+
return SDM:GetProgressionDataByAbilityId(rawAbilityId).abilityId
818+
end
812819

813820
--- update player values
814821
local function updatePlayerUltValue()
@@ -859,8 +866,11 @@ local function updatePlayerSlottedUlts()
859866
playerStats.ult.ult2Cost = 0
860867

861868
-- populate values
862-
playerStats.ult.ult1ID = GetSlotBoundId(ACTION_BAR_ULTIMATE_SLOT_INDEX + 1, HOTBAR_CATEGORY_PRIMARY)
863-
playerStats.ult.ult2ID = GetSlotBoundId(ACTION_BAR_ULTIMATE_SLOT_INDEX + 1, HOTBAR_CATEGORY_BACKUP)
869+
local rawUlt1ID = GetSlotBoundId(ACTION_BAR_ULTIMATE_SLOT_INDEX + 1, HOTBAR_CATEGORY_PRIMARY)
870+
local rawUlt2ID = GetSlotBoundId(ACTION_BAR_ULTIMATE_SLOT_INDEX + 1, HOTBAR_CATEGORY_BACKUP)
871+
872+
playerStats.ult.ult1ID = GetBaseAbilityId(rawUlt1ID)
873+
playerStats.ult.ult2ID = GetBaseAbilityId(rawUlt2ID)
864874
playerStats.ult.ult1Cost = GetAbilityCost(playerStats.ult.ult1ID, COMBAT_MECHANIC_FLAGS_ULTIMATE, nil, localPlayer)
865875
playerStats.ult.ult2Cost = GetAbilityCost(playerStats.ult.ult2ID, COMBAT_MECHANIC_FLAGS_ULTIMATE, nil, localPlayer)
866876

0 commit comments

Comments
 (0)