-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
As suggested in PR #1 by @sourcery-ai[bot]:
No test exists for get_optimization_recommendations when not Apple Silicon.
Task: Add a test case where _detect_apple_silicon returns False to verify correct recommendations for non-Apple Silicon systems.
Suggested implementation:
def test_get_optimization_recommendations_non_apple_silicon(self):
"""Test recommendations for non-Apple Silicon systems."""
with patch.object(MacOptimizer, '_gather_system_info', return_value={}):
with patch.object(MacOptimizer, '_detect_apple_silicon', return_value=False):
with patch.object(MacOptimizer, '_detect_unified_memory', return_value={'has_unified_memory': False, 'total_memory_gb': 16}):
with patch.object(MacOptimizer, '_get_cpu_details', return_value={'logical_cores': 8}):
with patch.object(MacOptimizer, '_get_gpu_details', return_value={'metal_support': False}):
optimizer = MacOptimizer()
recommendations = optimizer.get_optimization_recommendations()
assert recommendations['use_unified_memory'] is False
assert 'Use OpenCL or CUDA for GPU compute' in recommendations['architecture_specific']File: tests/test_mac_optimizer.py
Metadata
Metadata
Assignees
Labels
No labels