Skip to content

Commit 982ffde

Browse files
committed
stm32/mboot/Makefile: Revert change to BOARD_DIR that removed abspath.
This reverts the change from ce20586. Without abspath, the build artefacts (object files) for boards with source files are placed outside the build directory, because the BOARD_DIR variable starts with "..". For the list of source files added to SRC_C, none of them can start with "..". The usual fix for that would be to make the files relative to the top of the MicroPython repo (because of the vpath rule), eg ports/stm32/boards/$(BOARD). But then the $(wildcard ...) pattern won't find files in this directory. So abspath is necessary, although it will prevent building when there is a space in the path. A better solution for spaces needs to be found. Signed-off-by: Damien George <[email protected]>
1 parent 6bb446b commit 982ffde

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ports/stm32/mboot/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ BOARD ?= $(notdir $(BOARD_DIR:/=))
66
else
77
# If not given on the command line, then default to PYBV10.
88
BOARD ?= PYBV10
9-
BOARD_DIR ?= ../boards/$(BOARD)
9+
BOARD_DIR ?= $(abspath ../boards/$(BOARD))
1010
endif
1111

1212
# If the build directory is not given, make it reflect the board name.

0 commit comments

Comments
 (0)