Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should implement enum feature. #80

Open
romandev opened this issue Sep 17, 2017 · 3 comments
Open

Should implement enum feature. #80

romandev opened this issue Sep 17, 2017 · 3 comments
Assignees
@hwanseung

Comments

@romandev
Copy link
Member

romandev commented Sep 17, 2017 •
edited
Loading

We should implement enum feature.
https://heycam.github.io/webidl/#idl-enums
@romandev romandev changed the title Should implement enum features. Should implement enum feature. Sep 17, 2017
@hwanseung hwanseung self-assigned this Sep 18, 2017
@hwanseung
Copy link
Contributor

if anyone were not started yet, i will take care of this issue.

hwanseung added a commit to hwanseung/bacardi that referenced this issue Sep 18, 2017
@hwanseung
introduce Fragments class which is to be upper concept of interface.
03e80c1 
present barcardi is focused to interfaces, but Fragments are needed
to implment other things.
(eg. enums, dictionaries, typedefs and implements statements)

https://heycam.github.io/webidl/#dfn-idl-fragment

ISSUE=lunchclass#80
@hwanseung hwanseung mentioned this issue Sep 18, 2017
Merged
@yjaeseok
Copy link
Contributor

Cool~!

@romandev
Copy link
Member Author

Great!

hwanseung added a commit to hwanseung/bacardi that referenced this issue Sep 25, 2017
@hwanseung
introduce Fragments class which is to be upper concept of interface.
a1117b5 
present barcardi is focused to interfaces, but Fragments are needed
to implment other things.
(eg. enums, dictionaries, typedefs and implements statements)

https://heycam.github.io/webidl/#dfn-idl-fragment

ISSUE=lunchclass#80
romandev pushed a commit that referenced this issue Sep 27, 2017
@hwanseung @romandev
Introduce Fragments class which is to be upper concept of interface. (#…
bc981e2 
…84)

Current implementation is focused to interfaces, but Fragments are needed
to implement other things.
(eg. enums, dictionaries, typedefs and implements statements)

https://heycam.github.io/webidl/#dfn-idl-fragment

ISSUE=#80
@hwanseung hwanseung mentioned this issue Oct 8, 2017
Merged
romandev pushed a commit that referenced this issue Oct 8, 2017
@hwanseung @romandev
Implement IDL enum feature (#110)
aaa4167 
Implement IDL enum feature. Some part of codes should be generated
automatically at another files but this patch doesn't do that yet.
So, it will be finished in follow-up patch.

ISSUE=#80
@hwanseung hwanseung mentioned this issue Oct 8, 2017
Closed
romandev pushed a commit that referenced this issue Oct 18, 2017
@hwanseung @romandev
Introduce Fragments class which is to be upper concept of interface. (#…
1d2bd7b 
…84)

Current implementation is focused to interfaces, but Fragments are needed
to implement other things.
(eg. enums, dictionaries, typedefs and implements statements)

https://heycam.github.io/webidl/#dfn-idl-fragment

ISSUE=#80
romandev pushed a commit that referenced this issue Oct 18, 2017
@hwanseung @romandev
Implement IDL enum feature (#110)
bb3bb06 
Implement IDL enum feature. Some part of codes should be generated
automatically at another files but this patch doesn't do that yet.
So, it will be finished in follow-up patch.

ISSUE=#80
@hwanseung hwanseung mentioned this issue Oct 22, 2017
Merged
romandev pushed a commit that referenced this issue Oct 30, 2017
@hwanseung @romandev
Check enum values before pass to native side. (#145)
75f2507 
Check enum values before pass to native side.

ISSUE=#80
byeolbit pushed a commit to byeolbit/bacardi that referenced this issue Nov 16, 2017
@hwanseung
Check enum values before pass to native side. (lunchclass#145)
57c0001 
Check enum values before pass to native side.

ISSUE=lunchclass#80
hwanseung added a commit to hwanseung/bacardi that referenced this issue Nov 18, 2017
@hwanseung
Add tests for enum features
c4682b0 
 - add test for function which return enum values.
 - add test passing unexpected value instead of enum.

ISSUE=lunchclass#80
@hwanseung hwanseung mentioned this issue Nov 18, 2017
Merged
hwanseung added a commit to hwanseung/bacardi that referenced this issue Nov 18, 2017
@hwanseung
Add tests for enum features
9398058 
 - add test for function which return enum values.
 - add test passing unexpected value instead of enum.

ISSUE=lunchclass#80
romandev pushed a commit that referenced this issue Nov 18, 2017
@hwanseung @romandev
Add tests for enum features (#190)
e5123a5 
Add tests for enum features
  - Add test for function which return enum values
  - Add test passing unexpected value instead of enum

ISSUE=#80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hwanseung hwanseung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romandev @hwanseung @yjaeseok