Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bunch of lint errors #233

Open
6 of 8 tasks
romandev opened this issue Feb 14, 2018 · 1 comment
Open
6 of 8 tasks

A bunch of lint errors #233

romandev opened this issue Feb 14, 2018 · 1 comment

Comments

@romandev
Copy link
Member

I'm submitting a ...

  • bug report
  • feature request
  • support request

General information

Prerequisites

  • Are you running the latest version?

Description

There were a bunch of lint errors in latest code base. We are not sure why this happened but it's a blocker for many pending patches. We doubt upstream package's change but we should investigate it in details.

Steps to Reproduce

./bacardi lint_ts

Expected behavior:
No errors

Actual behavior:
You can see a bunch of errors

Context (Environment)

Operating System

  • Linux (x86/x64)
  • OSX (x86/x64)
  • Windows (x86/x64)
  • Linux (ARM)
romandev added a commit that referenced this issue Feb 14, 2018
@romandev
Fix some lint errors in latest code base
9f7a07c 
There were a bunch of lint errors in latest code base. We are not sure
why this happened but it's a blocker for many pending patches. So, we
should disable them temporarily and then re-enable them later (after
investigating in details).

This patch disables the following lint-rules:
  - no-implicit-dependencies
  - no-submodule-imports
  - no-unnecessary-class

ISSUE=#233
@romandev romandev mentioned this issue Feb 14, 2018
Merged
romandev added a commit that referenced this issue Feb 14, 2018
@romandev
Fix some errors in latest code base
c1d713d 
There were a bunch of errors in latest code base. We are not sure why
this happened but it's a blocker for many pending patches. So, we should
disable them temporarily and then re-enable them later (after
investigating in details).

This patch disables the following lint-rules:
  - no-implicit-dependencies
  - no-submodule-imports
  - no-unnecessary-class

This patch also disables the following build:
  - `./bacardi build_electron`

ISSUE=#233
romandev added a commit that referenced this issue Feb 14, 2018
@romandev
Fix some errors in latest code base (#234)
bc0c0a7 
There were a bunch of errors in latest code base. We are not sure why
this happened but it's a blocker for many pending patches. So, we should
disable them temporarily and then re-enable them later (after
investigating in details).

This patch disables the following lint-rules:
  - no-implicit-dependencies
  - no-submodule-imports
  - no-unnecessary-class

This patch also disables the following build:
  - `./bacardi build_electron`

ISSUE=#233
@nadongguri
Copy link
Contributor

If you remove ^ for all lint packages in package.json, those issues are gone. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romandev @nadongguri