Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split example test into feature unit tests. #100

Open
romandev opened this issue Oct 3, 2017 · 1 comment
Open

Split example test into feature unit tests. #100

romandev opened this issue Oct 3, 2017 · 1 comment

Comments

@romandev
Copy link
Member

romandev commented Oct 3, 2017

To implement POC ASAP, we didn't consider project structure much, especially, testing part. As the number of contributors grows, we need to write more tests and make the structure robust.
@hwanseung
Copy link
Contributor

i agree. for now testing code and example code are mixed.
so we should split test code from example code.
and that test code should not have coupling with example code.

romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Add test/test_interface.* for testing.
cdb4552 
This patch is adding a new test IDL interface to test/ directory.
After this patch, we can build a multiple IDL files and use them.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
@romandev romandev mentioned this issue Oct 7, 2017
Merged
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Add test/test_interface.* for testing. (#113)
347cec5 
This patch is adding a new test IDL interface to test/ directory.
After this patch, we can build a multiple IDL files and use them.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Introduce jest for testing.
2378344 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
@romandev romandev mentioned this issue Oct 7, 2017
Merged
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Introduce jest for testing.
730d9b3 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Introduce jest for testing.
a981c58 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Introduce jest for testing.
23a8f06 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Introduce jest for testing.
d62ee3e 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Introduce jest for testing. (#114)
b70ffd4 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 7, 2017
@romandev
Add some tests for constructor in IDL interface.
dbf2223 
Rewrite examples/ tests using jest.

ISSUE=#99,#100
@romandev romandev mentioned this issue Oct 7, 2017
Merged
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Add some tests for constructor in IDL interface. (#116)
80f0fbf 
Rewrite examples/ tests using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write a test for static method in IDL interface.
6032bf8 
ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write a test for static method in IDL interface.
3c4e832 
This patch also changes getCalledConstructorInfo() to static method and
rename it with getLastCallInfo() and then use it use generally.

ISSUE=#99,#100
@romandev romandev mentioned this issue Oct 8, 2017
Merged
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write a test for static method in IDL interface. (#117)
8de1fbb 
This patch also changes getCalledConstructorInfo() to static method and
rename it with getLastCallInfo() and then use it use generally.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write more tests in interface_static_method.test.ts
f2efaba 
Need more tests.

ISSUE=#99,#100
@romandev romandev mentioned this issue Oct 8, 2017
Merged
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write more tests in interface_static_method.test.ts (#118)
31e209a 
Need more tests.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write a test for Basic Types.
36b1cba 
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
@romandev romandev mentioned this issue Oct 8, 2017
Merged
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write a test for Basic Types.
23dd93e 
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Write a test for Basic Types. (#119)
47cd9e0 
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Enable --verbose option in test by default.
0832be9 
It's better to inform details.

ISSUE=#99,#100
@romandev romandev mentioned this issue Oct 8, 2017
Merged
romandev added a commit that referenced this issue Oct 8, 2017
@romandev
Enable --verbose option in test by default. (#121)
f617601 
It's better to inform details.

ISSUE=#99,#100
@hwanseung hwanseung mentioned this issue Oct 8, 2017
Merged
romandev pushed a commit that referenced this issue Oct 8, 2017
@hwanseung @romandev
Write a test for enum type using jest. (#122)
5459720 
Write a test for enum type using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Add test/test_interface.* for testing. (#113)
bae36e9 
This patch is adding a new test IDL interface to test/ directory.
After this patch, we can build a multiple IDL files and use them.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Introduce jest for testing. (#114)
0e8542c 
We are already using Mocha as testing framework but for some reasons
such as readability and convenience, we decided to use jest instead of
Mocha.

After this patch, ./bacardi test will run both of Mocha and jest.
Once we write test codes enough in jest, we will deprecate Mocha.

ISSUE=#99,#100
TBR=@hwanseung,@yjaeseok
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Add some tests for constructor in IDL interface. (#116)
0fa565e 
Rewrite examples/ tests using jest.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Write a test for static method in IDL interface. (#117)
4488430 
This patch also changes getCalledConstructorInfo() to static method and
rename it with getLastCallInfo() and then use it use generally.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Write more tests in interface_static_method.test.ts (#118)
6433cb0 
Need more tests.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Write a test for Basic Types. (#119)
5ea24d0 
Write a test for Basic Types such as boolean, short, double, and string.
Not include long type testing in this patch because it has some problem.
We should fix the issue in follow-up patch.

ISSUE=#99,#100
romandev added a commit that referenced this issue Oct 18, 2017
@romandev
Enable --verbose option in test by default. (#121)
d4e72e1 
It's better to inform details.

ISSUE=#99,#100
romandev pushed a commit that referenced this issue Oct 18, 2017
@hwanseung @romandev
Write a test for enum type using jest. (#122)
0cc9490 
Write a test for enum type using jest.

ISSUE=#99,#100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romandev @hwanseung