Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for lint in client/ #533

Open
romandev opened this issue Nov 17, 2017 · 2 comments
Open

Add support for lint in client/ #533

romandev opened this issue Nov 17, 2017 · 2 comments
Labels
absolute v2 good first issue

Comments

@romandev
Copy link
Member

Current lint command only affects server/ directory.
But we have already much codes in client/ directory as well.
So, we should make the lint command apply to client/ directory as well and fix all lint error.
@sapzape
Copy link
Contributor

sapzape commented Nov 17, 2017

I'll take this issue :)

@romandev
Copy link
Member Author

@sapzape Go ahead! Thanks :)

This was referenced Nov 17, 2017
Closed
Closed
Merged
romandev pushed a commit that referenced this issue Nov 22, 2017
@sapzape @romandev
Modified lint command to accept multiple arguments (#537)
7937ac6 
This change fixes the lint command apply to client/ directory as well.

ISSUE=#533
@sapzape sapzape mentioned this issue Nov 24, 2017
Merged
romandev pushed a commit that referenced this issue Nov 24, 2017
@sapzape @romandev
Fixed some lint errors in client area using 'lint:fix' (#540)
90d649c 
Performed the `lint:fix` command. That fixes some lint errors in
`client/` directory.

ISSUE=#533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
absolute v2 good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romandev @sapzape