Rd 2 6508 when send only if error true tracer should always create a file (#232)

* fix: stop file for when send_only_if_error = TRUE

Author: OrrLumigo

src/lumigo_tracer/lumigo_utils.py

@@ -385,6 +385,7 @@ def get_span_file_name(span_type: str):
 
 
 def write_extension_file(data: List[Dict], span_type: str):
+    Path(get_extension_dir()).mkdir(parents=True, exist_ok=True)
     to_send = aws_dump(data).encode()
     file_path = get_span_file_name(span_type)
     with open(file_path, "wb") as span_file:
@@ -396,7 +397,6 @@ def write_spans_to_files(
     spans: List[Dict], max_spans=MAX_NUMBER_OF_SPANS, is_start_span=True
 ) -> None:
     to_send = spans[:max_spans]
-    Path(get_extension_dir()).mkdir(parents=True, exist_ok=True)
     if is_start_span:
         get_logger().info("Creating start span file")
         write_extension_file(to_send, "span")

src/lumigo_tracer/spans_container.py

@@ -25,6 +25,7 @@
     is_provision_concurrency_initialization,
     get_stacktrace,
     write_extension_file,
+    should_use_tracer_extension,
 )
 from lumigo_tracer import lumigo_utils
 from lumigo_tracer.parsing_utils import parse_trace_id, safe_split_get, recursive_json_join
@@ -278,7 +279,8 @@ def end(self, ret_val=None, event: Optional[dict] = None, context=None) -> Optio
             get_logger().debug(
                 "No Spans were sent, `Configuration.send_only_if_error` is on and no span has error"
             )
-            # write_extension_file([{}], "stop")
+            if should_use_tracer_extension():
+                write_extension_file([{}], "stop")
         return reported_rtt
 
     def _set_error_extra_data(self, event):

src/test/unit/test_spans_container.py

@@ -1,4 +1,6 @@
 import copy
+import os
+
 import mock
 import inspect
 import json
@@ -62,20 +64,33 @@ def test_spans_container_end_function_got_none_return_value(monkeypatch):
 def test_spans_container_end_function_not_send_spans_on_send_only_on_errors_mode(
     monkeypatch, dummy_span, tmpdir
 ):
+    monkeypatch.setenv("LUMIGO_USE_TRACER_EXTENSION", "TRUE")
+    reported_ttl, stop_path_path = only_if_error(dummy_span, monkeypatch, tmpdir)
+    stop_file_content = json.loads(open(stop_path_path, "r").read())
+    assert json.dumps(stop_file_content) == json.dumps([{}])
+    assert reported_ttl is None
+
+
+def test_spans_container_end_shoudnt_create_file_if_not_using_extension(
+    monkeypatch, dummy_span, tmpdir
+):
+    reported_ttl, stop_path_path = only_if_error(dummy_span, monkeypatch, tmpdir)
+    assert os.path.isfile(stop_path_path) is False
+    assert reported_ttl is None
+
+
+def only_if_error(dummy_span, monkeypatch, tmpdir):
     extension_dir = tmpdir.mkdir("tmp")
     monkeypatch.setenv("LUMIGO_EXTENSION_SPANS_DIR_KEY", extension_dir)
     monkeypatch.setattr(uuid, "uuid4", lambda *args, **kwargs: "span_name")
     Configuration.send_only_if_error = True
-
     SpansContainer.create_span()
     SpansContainer.get_span().start()
-    SpansContainer.get_span().add_span(dummy_span)
 
+    SpansContainer.get_span().add_span(dummy_span)
     reported_ttl = SpansContainer.get_span().end({})
     stop_path_path = f"{lumigo_utils.get_extension_dir()}/span_name_stop"
-    stop_file_content = json.loads(open(stop_path_path, "r").read())
-    assert json.dumps(stop_file_content) == json.dumps([{}])
-    assert reported_ttl is None
+    return reported_ttl, stop_path_path
 
 
 def test_spans_container_end_function_send_spans_on_send_only_on_errors_mode(
@@ -99,7 +114,6 @@ def test_spans_container_end_function_send_spans_on_send_only_on_errors_mode(
 def test_spans_container_end_function_send_only_on_errors_mode_false_not_effecting(
     monkeypatch, dummy_span
 ):
-
     SpansContainer.create_span()
     SpansContainer.get_span().start()