RD-10381 - do not add W3C TraceContext headers to Amazon Sigv4 outgoing HTTP requests (#272)

* feat: do not add W3C TraceContext headers to Amazon Sigv4 outgoing HTTP requests

* remove codeowners

Author: saartochner-lumigo

.github/CODEOWNERS

@@ -2,6 +2,8 @@
 import re
 from typing import Dict, Optional
 
+from lumigo_core.logger import get_logger
+
 TRACEPARENT_HEADER_NAME = "traceparent"
 TRACESTATE_HEADER_NAME = "tracestate"
 # The regex was copied from:
@@ -10,13 +12,21 @@
     "^[ \t]*([0-9a-f]{2})-([0-9a-f]{32})-([0-9a-f]{16})-([0-9a-f]{2})" + "(-.*)?[ \t]*$"
 )
 TRACEPARENT_HEADER_FORMAT_RE = re.compile(TRACEPARENT_HEADER_FORMAT)
+SKIP_INJECT_HEADERS = ["x-amz-content-sha256"]
 
 
 def generate_message_id() -> str:
     return "%016x" % random.getrandbits(64)
 
 
+def should_skip_trace_propagation(headers: Dict[str, str]) -> bool:
+    return any(key.lower() in SKIP_INJECT_HEADERS for key in headers)
+
+
 def add_w3c_trace_propagator(headers: Dict[str, str], transaction_id: str) -> None:
+    if should_skip_trace_propagation(headers):
+        get_logger().debug("Skipping trace propagation")
+        return
     message_id = generate_message_id()
     headers[TRACEPARENT_HEADER_NAME] = get_trace_id(headers, transaction_id, message_id)
     headers[TRACESTATE_HEADER_NAME] = get_trace_state(headers, message_id)

src/lumigo_tracer/w3c_context.py

@@ -6,6 +6,7 @@
     add_w3c_trace_propagator,
     get_w3c_message_id,
     is_w3c_headers,
+    should_skip_trace_propagation,
 )
 
 
@@ -78,3 +79,23 @@ def test_get_w3c_message_id(headers, expected):
 )
 def test_is_w3c_headers(headers, expected):
     assert is_w3c_headers(headers) == expected
+
+
+@pytest.mark.parametrize(
+    "headers, expected",
+    [
+        ({}, False),
+        ({"another": "header"}, False),
+        ({"x-amz-content-sha256": "123"}, True),
+        ({"X-amz-content-SHA256": "123"}, True),
+    ],
+)
+def test_should_skip_trace_propagation(headers, expected):
+    assert should_skip_trace_propagation(headers) == expected
+
+
+def test_dont_add_header_for_skipped_context():
+    headers = {"x-amz-content-sha256": "123"}
+    add_w3c_trace_propagator(headers, "111111111111112222222222")
+
+    assert headers == {"x-amz-content-sha256": "123"}