change legit error to info & don't include end_time in HTTP requests before request finished (#240)

* change legit error to info

* started request that haven't finished shouldn't have ended time

Co-authored-by: CircleCI <[email protected]>

Author: saartochner-lumigo

src/lumigo_tracer/lumigo_utils.py

@@ -373,7 +373,7 @@ def report_json(
         internal_analytics_message("report: socket.timeout")
     except Exception as e:
         if should_retry:
-            get_logger().exception(f"Could not report to {host}. Retrying.", exc_info=e)
+            get_logger().info(f"Could not report to {host}. Retrying.", exc_info=e)
             edge_connection = establish_connection(host)
             report_json(region, msgs, should_retry=False)
         else:

src/lumigo_tracer/spans_container.py

@@ -190,9 +190,9 @@ def update_event_times(
         """
         if span_id in self.spans:
             start_timestamp = start_time.timestamp() if start_time else time.time()
-            end_timestamp = end_time.timestamp() if end_time else time.time()
             self.spans[span_id]["started"] = int(start_timestamp * 1000)
-            self.spans[span_id]["ended"] = int(end_timestamp * 1000)
+            if end_time:
+                self.spans[span_id]["ended"] = end_time.timestamp()
         else:
             get_logger().warning(f"update_event_times: Got unknown span id: {span_id}")
 

src/test/unit/test_spans_container.py

@@ -247,3 +247,12 @@ def test_malformed_txid(monkeypatch, context):
     result = SpansContainer.get_span().get_patched_root()
     output_trace_id = result.split(";")[0].split("=")[1].split("-")[2]
     assert output_trace_id == SpansContainer.get_span().transaction_id
+
+
+def test_unfinished_request():
+    container = SpansContainer.get_span()
+    container.add_span({"id": "1", "extra": "a"})
+    start = datetime(2022, 2, 21, 1, 1)
+    container.update_event_times(span_id="1", start_time=start)
+    assert container.get_span_by_id("1")["started"]
+    assert "ended" not in container.get_span_by_id("1")