Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

way to make it a bit faster #5

Open
jwinkler2083233 opened this issue Aug 28, 2021 · 1 comment
Open

way to make it a bit faster #5

jwinkler2083233 opened this issue Aug 28, 2021 · 1 comment

Comments

@jwinkler2083233
Copy link

Thanks for making this.

I noticed that you're putting the comparison at the top of the assembly functions.
If you put the comparisons at the end, it would be a bit faster. You can assume that there is at least one element.

It's like using 'for ()' when you could instead use 'do...while{}'

@lukechampine
Copy link
Owner

That would save what, 1 CMP? Doesn't seem worth it to me. But if you make a PR and the benchmark shows an improvement, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants