New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Block Editing not working when in popout window #19

Open

elrindir opened this issue Dec 5, 2023 · 0 comments

Assignees

elrindir commented Dec 5, 2023

Describe the bug
The Code Block Editing feature as of v1.1.0 is not working in Obsidian's built-in pop-out window.

To Reproduce

Create a new note
Write a code block and some code
Press Ctrl + P
select "Open current tab in new window"
navigate to the new window
right click on the code block
click "Edit Code Block in Monaco Editor"
editor modal opens
no content is displayed, changes have no effect

Expected behavior

editor modal opens in pop-out window
content of the codeblock is displayed
changes are applied to the codeblock after closing the editor

Screenshots

Additional context
Additional details:

Tested only on Desktop
Windows 10, Obsidian v1.4.16
I've noticed some other plugins, which were also broken in pop-out windows. For example see here.
Also, when the editor modal is open in the pop-out window, hotkeys do not work in the main Obsidian window. After closing the modal, hotkeys are fine again.

elrindir assigned lukasbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment