vuln-fix: Zip Slip Vulnerability

This fixes a Zip-Slip vulnerability.

This change does one of two things. This change either

1. Inserts a guard to protect against Zip Slip.
OR
2. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`.

For number 2, consider `"/usr/outnot".startsWith("/usr/out")`.
The check is bypassed although `/outnot` is not under the `/out` directory.
It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object.
For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`;
however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`.

Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')
Severity: High
CVSSS: 7.4
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-zipslip/) & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.ZipSlip)

Reported-by: Jonathan Leitschuh <[email protected]>
Signed-off-by: Jonathan Leitschuh <[email protected]>

Bug-tracker: JLLeitschuh/security-research#16

Co-authored-by: Moderne <[email protected]>

Author: JLLeitschuh

graph-builder/src/main/java/spoon/decompiler/FernflowerDecompiler.java

@@ -66,7 +66,10 @@ private void unzipJar(String toBeExtractedJar, String destDir) throws IOExceptio
 			java.util.Enumeration enumEntries = jar.entries();
 			while (enumEntries.hasMoreElements()) {
 				java.util.jar.JarEntry file = (java.util.jar.JarEntry) enumEntries.nextElement();
-				java.io.File f = new java.io.File(destDir + java.io.File.separator + file.getName());
+				java.io.File f = new File(destDir, file.getName());
+       if(!f.toPath().normalize().startsWith(destDir)) {
+           throw new IOException("Bad zip entry");
+       }
 				f.getParentFile().mkdirs();
 				if (file.isDirectory()) { // if its a directory, create it
 					f.mkdir();