Skip to content

add super and subscript support#49

Merged
lpil merged 2 commits into
lpil:mainfrom
0xda157:super-subscript
Jun 5, 2026
Merged

add super and subscript support#49
lpil merged 2 commits into
lpil:mainfrom
0xda157:super-subscript

Conversation

@0xda157

@0xda157 0xda157 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/jot.gleam
Comment on lines +754 to +757
fn parse_thematic_break(
count: Int,
in: String,
) -> Option(#(Container, String)) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformatting changes here are due to me using Gleam 1.16.0 locally while the CI uses Gleam 1.14.0. how should I handle this?

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll upgrade CI 👍

Comment thread src/jot.gleam
}

fn parse_insert_delete_mark(
fn parse_insert_delete_mark_sup_sub(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function name is getting quite lengthy, but I'm not sure what to rename it to.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Better than too short :)

@0xda157 0xda157 force-pushed the super-subscript branch from 754e6f2 to 2b2b49e Compare June 4, 2026 18:52
@0xda157 0xda157 force-pushed the super-subscript branch from 2b2b49e to 103168b Compare June 4, 2026 18:55

@lpil lpil left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Lovely work

@lpil lpil merged commit 0711a8f into lpil:main Jun 5, 2026
1 check passed
@0xda157 0xda157 deleted the super-subscript branch June 5, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants