Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server_no_context_takeover #7

Open
barkyq opened this issue Feb 14, 2023 · 3 comments
Open

server_no_context_takeover #7

barkyq opened this issue Feb 14, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@barkyq
Copy link

barkyq commented Feb 14, 2023

If I send the following header in the websocket handshake:

Sec-WebSocket-Extensions: permessage-deflate; server_no_context_takeover

The returned handshake response says the server does not want to use permessage-deflate.

But if I just send:

Sec-WebSocket-Extensions: permessage-deflate

The returned handshake response says the server does want to use permessage-deflate.

From: https://www.rfc-editor.org/rfc/rfc7692, "It is RECOMMENDED that a server supports the server_no_context_takeover extension parameter in an extension negotiation offer."

@barkyq
Copy link
Author

barkyq commented Feb 14, 2023

Kudos for supporting compression. Most relays (e.g., nostream, nostr-rs-relay) don't. The only other one AFAICT is strfry

@barkyq
Copy link
Author

barkyq commented Feb 14, 2023

not really an issue either, it might be intentional. the compression is much better if the server can do context_takeover in any case.

@lpicanco
Copy link
Owner

Thanks @barkyq, I will take a look on it.

@lpicanco lpicanco added the enhancement New feature or request label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants