Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to edit the notification that is being sent out #3048

Closed
1 task done
4n0nh4x0r opened this issue Apr 8, 2023 · 6 comments
Closed
1 task done

Being able to edit the notification that is being sent out #3048

4n0nh4x0r opened this issue Apr 8, 2023 · 6 comments
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added

Comments

@4n0nh4x0r
Copy link

4n0nh4x0r commented Apr 8, 2023

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification, UI Feature

🔖 Feature description

As the title already says.
It would be nice to be able to specify what a notification sends.
Like for example, if i dont want to expose the ip address of the server where my backend service runs on, it would be nice to be able to at least disabled that the notification sends out the service url.
Even better would be being able to fully customize the notification but well, i can assume how much work that would be, so it would already be nice to just be able to toggle the visibility of certain parts of the message.

✔️ Solution

Having options in the notification setup that you can toggle to enable/disable this specific notification from showing a certain part of the information like for example the service url or the ping.
At least a toggle to disable the service url from being shown on the notification you are editing.

❓ Alternatives

Alternatively one could allow the user to create their own notification with maybe a specific json object template they have to edit themselves, or just some text boxes that fill the json object behind the scenes

📝 Additional Context

No response

@4n0nh4x0r 4n0nh4x0r added the feature-request Request for new features to be added label Apr 8, 2023
@jonnymccullagh
Copy link

I would like this too, with another (optional) textbox under 'Description' for 'Notification Message' that could include info on how to deal with the problem or a link to a Playbook.

@4n0nh4x0r
Copy link
Author

I would like this too, with another (optional) textbox under 'Description' for 'Notification Message' that could include info on how to deal with the problem or a link to a Playbook.

ooooo, it would be nice to be able to automate actions if something goes south
like for example making it so if a service goes down lets say in the middle of the night and you dont notice it being down for lets say 5 minutes, that the system automatically tries to restart the service or even the whole server
but it would also be nice to be able to set custom responses for certain error codes, for example if a nextcloud server gives out a 500 error, yknow that something is really going wrong, possibly a redis server or the db server down or something like that, and then the notification could tell you the error code and what problems could be causing this (tho this would be more of a manual thing to add as a custom message)

@CommanderStorm
Copy link
Collaborator

@4n0nh4x0r is this a duplicate of #1529 #2661 #2617 #2387 and more (see #646 for a deeper discussion)

If yes, please close this issue. Duplicates just make issue management harder.
If no, please edit the title+description to make this more distinct (and comment to notify the other participants)

@jonnymccullagh
Copy link

jonnymccullagh commented Jun 5, 2023

Yes duplicate of #646 - I would say close this issue

@CommanderStorm
Copy link
Collaborator

@4n0nh4x0r could you close this issue?
(only you or Louis can close issues for permission reasons)

@CommanderStorm CommanderStorm added the area:notifications Everything related to notifications label Dec 3, 2023
@CommanderStorm
Copy link
Collaborator

@4n0nh4x0r
We are consolidating duplicate issues a bit to make issue management easier.
I think, we should track this issue in #2387 as there is no functional difference (maybe just small naming differences, but nothing that would require a different issue imo)
⇒ I am going to close this as a duplicate.

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added
Projects
None yet
Development

No branches or pull requests

3 participants