Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minimum interval value #1645

Open
1 task done
melvinlemoine opened this issue May 15, 2022 · 25 comments · May be fixed by #1740
Open
1 task done

Remove minimum interval value #1645

melvinlemoine opened this issue May 15, 2022 · 25 comments · May be fixed by #1740
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added

Comments

@melvinlemoine
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

Other

🔖 Feature description

Remove the interval of 20 seconds minimum from heartbeat interval & heartbeat retry interval.

✔️ Solution

Remove the interval of 20 seconds minimum from heartbeat interval & heartbeat retry interval. I need to monitore under 20 seconds and each time I need to save my 10s seconds interval & 5s retry interval I need to remove min="20" from HTML.

❓ Alternatives

No response

📝 Additional Context

No response

@melvinlemoine melvinlemoine added the feature-request Request for new features to be added label May 15, 2022
@ylluminate
Copy link

ylluminate commented May 23, 2022

This is a very important feature when this is being used for gateway and ISP monitoring. This should be able to go down to at least 1 second intervals.

This was also requested here: #1015

Seems like key files to resolve this are found here:
https://github.com/louislam/uptime-kuma/search?q=heartbeat+20

@yurividal

This comment was marked as spam.

@akinnee
Copy link

akinnee commented Jun 1, 2022

I don't see the reason for a minimum when it's self-hosted.

@Computroniks
Copy link
Contributor

+1. I don't see the reason for a minimum when it's self-hosted.

I don't know, but I think that it was probably added to prevent poor performance with lots of monitors. Having said that, no reason why we couldn't just add a warning saying as much if the user drops it below 20

@Laukage

This comment was marked as spam.

@akinnee
Copy link

akinnee commented Jun 7, 2022

+1. I don't see the reason for a minimum when it's self-hosted.

I don't know, but I think that it was probably added to prevent poor performance with lots of monitors. Having said that, no reason why we couldn't just add a warning saying as much if the user drops it below 20

Yep. I'd say allow us to shoot ourselves in the foot, but warn that we might do so. 😄

@Laukage
Copy link

Laukage commented Jun 7, 2022

+1. I don't see the reason for a minimum when it's self-hosted.

I don't know, but I think that it was probably added to prevent poor performance with lots of monitors. Having said that, no reason why we couldn't just add a warning saying as much if the user drops it below 20

Yep. I'd say allow us to shoot ourselves in the foot, but warn that we might do so. 😄

How so? Many ping tools has 1sec intervals

Computroniks added a commit to Computroniks/uptime-kuma that referenced this issue Jun 8, 2022
Computroniks added a commit to Computroniks/uptime-kuma that referenced this issue Jun 8, 2022
louislam#1645 has been added by changing the minimum value from 20 to 1. A
warning has been added that shows when the user enters a value less than
20 to state that performance issues may be enountered.

Signed-off-by: Matthew Nickson <[email protected]>
Computroniks added a commit to Computroniks/uptime-kuma that referenced this issue Jun 9, 2022
louislam#1645 has been added by changing the minimum value from 20 to 1. A
warning has been added that shows when the user enters a value less than
20 to state that performance issues may be enountered.

Signed-off-by: Matthew Nickson <[email protected]>
@jwklijnsma
Copy link

any update on this ?

@Computroniks
Copy link
Contributor

It has been implemented in #1740 and is awaiting merge

@jwklijnsma
Copy link

we will i be mirg ?

@KRider92
Copy link

Bumping this... @louislam is there any chance this will be merged soon?

@Computroniks
Copy link
Contributor

Bumping this... @louislam is there any chance this will be merged soon?

I need to implement some of the changes identified in the PR before it can be merged, most notably requiring the user to confirm that they actually want to go below 20 seconds. More info can be found in the #1740 thread. I will probably get around to implementing this in the next 1 or two weeks

Computroniks added a commit to Computroniks/uptime-kuma that referenced this issue Oct 1, 2022
@ImFound ImFound mentioned this issue Nov 10, 2022
@MostHated
Copy link

Any movement planned on this? This is definitely a much needed change. 20 seconds is basically an eternity for important/critical/actionable info.

@CommanderStorm
Copy link
Collaborator

Please refer to what was previously posted

More info can be found in the #1740 thread

TLDR: As long as the performance issues are not resolved, this will not get merged. There are a few performance optimisations implemented in 1.23 and some in 2.0
⇒ let's see if this addresses the issue enough to make this a good change from a support perspective. Adding this without fixing the underlying performance issues is not a thing we can do.

@yurividal
Copy link

Please refer to what was previously posted

More info can be found in the #1740 thread

TLDR: As long as the performance issues are not resolved, this will not get merged. There are a few performance optimisations implemented in 1.23 and some in 2.0 ⇒ let's see if this addresses the issue enough to make this a good change from a support perspective. Adding this without fixing the underlying performance issues is not a thing we can do.

I haven't looked at the code (and I am, by no means, a professional developer), but, one thing I know is that apps like telegraf, and PRTG, which allow for hundreds of ping sensors with minimal intervals is that they seem to spin a separate thread for every ping. Do you know if this is the same approach Kuma is taking?

@Computroniks
Copy link
Contributor

I haven't looked at the code (and I am, by no means, a professional developer), but, one thing I know is that apps like telegraf, and PRTG, which allow for hundreds of ping sensors with minimal intervals is that they seem to spin a separate thread for every ping. Do you know if this is the same approach Kuma is taking?

If I remember correctly, the issue is not with the actual running of the tests, but with the backend database, particularly the calculation for the uptime requiring very large queries which end up overloading the database. More info is in #2750.

@Axsgranted
Copy link

I too am looking for less than 20 second intervals but I'm guessing this merge is dead now? I mean after 2 years...

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Apr 27, 2024

In v1 the dangers of such an option are too high (v1 can only cope with a db of 1..10GB depending on storage and retention).
From a support perspective I can't in good faith support merging this.
I am struggling to respond to users/reviewing PRs as is.

See comment from above:

As long as the performance issues are not resolved, this will not get merged. There are a few performance optimisations implemented in 1.23 and some in 2.0
⇒ let's see if this addresses the issue enough to make this a good change from a support perspective. Adding this without fixing the underlying performance issues is not a thing we can do.

=> v2.0 is tracked in #4500 but has some bugs that need adressing before we can release the first beta. If a benchmark gets made we and said benchmark proves that this PR is possible, we can merge it (removing the warning)

@xvertile
Copy link

I have created a fork of the latest version where the minimum interval is disabled you can find it here:

https://github.com/xvertile/uptime-kuma

Cheers

@AhmadMuj
Copy link

Can we have any update on this please ?

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Oct 20, 2024

The situation has not changed from my last post #1645 (comment).
We/someone from the community have not made a benchmark to see if multiplying the load by 20x is acceptable.

Why we are so cautions with this is explained by the fact that 500 monitors @ 20s is equivalent to 25 monitors @ 1s..
v2.0 should better for this usecase, but it might not be enough...

@Axsgranted
Copy link

Could you not simply have a warning when setting it lower than 20seconds?

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Oct 21, 2024

See my last post #1645 (comment)

In v1 the dangers of such an option are too high (v1 can only cope with a db of 1..10GB depending on storage and retention).
From a support perspective I can't in good faith support merging this. I am struggling to respond to users/reviewing PRs as is.

=> without having validated that this is not still a massive footgun/actively dangerous, I won't merge the PR.

@oskerlau
Copy link

I have created a fork of the latest version where the minimum interval is disabled you can find it here:

https://github.com/xvertile/uptime-kuma

Cheers

Great !! Is there a docker image?

@Kristoffeh
Copy link

Great !! Is there a docker image?

Did you get this tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors feature-request Request for new features to be added
Projects
None yet
Development

Successfully merging a pull request may close this issue.