Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potentially Problematic #18

Open
reubingeorge opened this issue Jul 19, 2023 · 1 comment
Open

Potentially Problematic #18

reubingeorge opened this issue Jul 19, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@reubingeorge
Copy link

reubingeorge commented Jul 19, 2023 •
edited
Loading

pyregex/pyregexp/engine.py

Line 427 in 1fde108

elif isinstance(curr_node, LeafNode):

there is no attribute "min" or "max" in the LeafNode class..
@lorenzofelletti
Copy link
Owner

You're right.
While not technically a bug, because since every subclass has both attributes the code works fine, it is for sure an improvement that should be done! Thank you for pointing it out. Feel free to implement this and submit a PR if you like, I will work on it as soon I have a little spare time.

@lorenzofelletti lorenzofelletti added enhancement New feature or request good first issue Good for newcomers labels Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reubingeorge @lorenzofelletti