Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action_manager): Action Manager module integration #184

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Commits on Sep 3, 2022

  1. refactor(ActionDescriptor,ActionList,ActionReference): better type co…

    …mmunication and completes functions in photoshop js reference
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    9537f5f View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. refactor(Session): fix Action Manager things in session

    I may have to correct something about Action Manager and its classes: ActionDescriptor, ActionList, ActionReference. Action Manager is NOT something to describe your action palette. Action Manager actually enables low-level access into photoshop, and all things in this repo can actually be rewritten in Action Manager. You can consider an ActionDescriptor as dict, ActionList as array, ActionReference as filters for searching. So we should NOT set an INSTANCE of ActionDescriptor as an attribute of a Session and instead we should set the ActionDescriptor CLASS (the same for ActionList, ActionReference).
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    e339e77 View commit details
    Browse the repository at this point in the history
  2. feat(action_manager): Integrated my AM types and utilities

    desc_value_types and ref_form_types defines classes which describes AM things and utils contains a shortcut for id conversion.
    
    Nothing breaking. All AM functions are still available.
    
    My submodule uses relative importing because absolute importing causes bigger possibility in path typos.
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ddc651b View commit details
    Browse the repository at this point in the history
  3. feat(jprint): adds 'prefix' option to add a prefix before am keywords

    For example, I advice to do 'import photoshop.api.action_manager as am'. Then jprint(prefix='am') should be helpful.
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b642518 View commit details
    Browse the repository at this point in the history
  4. docs(examples): change all examples which uses Action Manager to make…

    … use of my submodule
    
    In fact, why use those ****s born by ScriptListener Plug-in which is totally unreadable?
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    520018e View commit details
    Browse the repository at this point in the history
  5. docs(action_manager): all equipped with doc strings

    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    37bdb4a View commit details
    Browse the repository at this point in the history
  6. fix(action_manager): patch to support py37

    change patching to (try eval + except), and now run black -l 80 to avoid hound warning
    
    There will be lots of violations in hound's eye which I cannot find out locally because hound's linter is not up to date. I will have to do some shattered commits, and for these commits, I will name them hop (hound oriented programming).
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    b2b2b0e View commit details
    Browse the repository at this point in the history
  7. fix(action_manager,examples): fix support for Path(AliasType) and fix…

    … import picture example
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    04e9362 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. fix(action_manager/utils): 1. Requires initialization of app when nee…

    …ded instead of do it on import to pass import test. 2. Warns user when typeID collision happens. (And id2str will try to avoid giving user string that will cause collision.)
    
    typeID collision happens when a stringID and a charID share the same name. For example, charID 'From' -> stringID 'from' and charID 'from' -> stringID 'originalAddressAttr', so 'from' is a string that will cause collision. After scanning the cpp header "PITerminology.h" and "PIStringTerminology.h", I found 3 such strings and hardcoded them into utils.py. str2id() will not automatically correct user when user gives a collision string (because no one knows what he want it to be a stringID or an charID!), but will regard that string as stringID and throw a warning. Users can follow that warning's guide to fix error and suppress that warning.
    
    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    2712d1c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. style(action_manager/js_converter): hop

    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    9b1a39a View commit details
    Browse the repository at this point in the history
  2. chore(ci): update hound to ignore BLK100

    Signed-off-by: longhao <[email protected]>
    loonghao authored and TsXor committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    135478c View commit details
    Browse the repository at this point in the history
  3. style(action_manager/js_converter): hop

    Signed-off-by: TsXor <[email protected]>
    TsXor committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    387387f View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2022

  1. Configuration menu
    Copy the full SHA
    202df61 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. Configuration menu
    Copy the full SHA
    7d1b13a View commit details
    Browse the repository at this point in the history
  2. fix(action_descriptor): fix a little typo

    Signed-off-by: 23Xor <[email protected]>
    TsXor committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    f77694b View commit details
    Browse the repository at this point in the history