Add star ( * ) to required field names

[BennyAlex]

In MUI as well in material design in gerneral, required field are indicated by a * at the end of the name.
It would be helpfull, if this would be added automatically to any field marked as required in yup.

[lookfirst]

Hi there, thanks for the comment. I've moved this to a discussion.

Have you tried this method? https://github.com/lookfirst/mui-rff#makerequiredschema

[BennyAlex]

Yeah I use the makeRequired function but this doesn't add a star to the label.
When setting required={true} it does work.

[BennyAlex]

The problem is, that all fields in the required object are false:

[lookfirst]

Ah, that codesandbox is using a really really old version of mui-rff, and as we all know, javascript code rots over time. You have to stay up to date with the latest of things for anything to work properly.

What I did was run the example in the latest version (cd example; yarn; yarn start), and added the console.log in the same place that you did in the codesandbox... as you can see, everything works just fine.

I hope this helps you.

[BennyAlex]

@lookfirst
Hey, thanks for have a look. However, I cant get it to work, neither locally or on codesandbox.
See here please: https://codesandbox.io/s/pedantic-snow-czymrw

[lookfirst]

I was using a field in Yup schema that wasn't exposed in order to get that required data. It was a bit hacky because Yup didn't make this information as part of their public api. I even filed an issue years ago, but got no love. jquense/yup#622

It seems that Yup finally broke it in 1.x.

Pin the dependency to 0.32.x (which is the dep in mui-rff) and things start to work again.

Now, the question going forward... how to fix this in Yup? I don't know... what I did before was set a breakpoint and then look deeply into the schema object to find what I wanted. Maybe they just moved things around or maybe they just made things really difficult.

I've been also thinking that switching to zod might also be a good idea, but I haven't found the motivation yet and I hate to break people's code.

[BennyAlex]

yeah i thought also that it has to do with yup. You should make it an optional peer dependency with yup <= 0.32

[lookfirst]