Skip to content

Fix find column#21

Open
myounglai wants to merge 2 commits into
looker-open-source:mainfrom
myounglai:fix_find_column
Open

Fix find column#21
myounglai wants to merge 2 commits into
looker-open-source:mainfrom
myounglai:fix_find_column

Conversation

@myounglai
Copy link
Copy Markdown

No description provided.

@fzakaria fzakaria force-pushed the master branch 3 times, most recently from d292112 to 933b6f0 Compare October 12, 2020 22:50
@lewisdawson
Copy link
Copy Markdown

@jonathanswenson Was there a specific reason this fix has never been merged in? It fixes the exception:

No Such column labeled: idnet.starschema.clouddb.jdbc.BQSQLException: No Such column labeled

that is thrown when one tries to do a column label lookup with resultSet.get<type>(<columnName>).

@fzakaria
Copy link
Copy Markdown

Sorry this has not been looked at it.

Can you rebase your changes and tag me; I can review.

@fzakaria fzakaria self-requested a review June 28, 2022 16:15
@fzakaria
Copy link
Copy Markdown

Thank you for the contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants