Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer is not defined with 0.2.3 #15

Closed
castasamu opened this issue Apr 22, 2020 · 7 comments
Closed

Buffer is not defined with 0.2.3 #15

castasamu opened this issue Apr 22, 2020 · 7 comments

Comments

@castasamu
Copy link

I try use simpl-schema but with version 0.2.3 the console says:

Buffer is not defined.

@dovydaskukalis
Copy link

Same issue, caused by adding deep-extend as a dep. unclechu/node-deep-extend#42

@pward123
Copy link

See #9

@aldeed
Copy link
Collaborator

aldeed commented Apr 23, 2020

Ha, we've come full circle. Forgot about that issue. For those seeing this, is it only with React Native?

@dovydaskukalis
Copy link

Ha, we've come full circle. Forgot about that issue. For those seeing this, is it only with React Native?

For me it’s Meteor. I just posted a similar issue. What’s interesting is that we already include global.Buffer = global.Buffer || require('buffer').Buffer before importing anything using simple-schema as we have another module which needs buffers but for some reason this one crashes website as if buffer doesn’t exist.

@aldeed
Copy link
Collaborator

aldeed commented Apr 23, 2020

Might switch to deepmerge. It's smaller than most of the others and seemingly maintained. I don't see any references to Buffer in its codebase.

@aldeed aldeed closed this as completed in c329dca Apr 23, 2020
@aldeed
Copy link
Collaborator

aldeed commented Apr 23, 2020

Fixed in 0.2.4

@aldeed
Copy link
Collaborator

aldeed commented Apr 23, 2020

Additional fix in 0.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants