Skip to content

chore: createNode security hardening + source move to src#5

Merged
NagyZoltanPeter merged 19 commits intomasterfrom
chore-enhance-api-sequrity-and-data
Apr 15, 2026
Merged

chore: createNode security hardening + source move to src#5
NagyZoltanPeter merged 19 commits intomasterfrom
chore-enhance-api-sequrity-and-data

Conversation

@NagyZoltanPeter
Copy link
Copy Markdown
Collaborator

@NagyZoltanPeter NagyZoltanPeter commented Feb 25, 2026 •
edited
Loading

Summary

  • creatNode security hardening
  • source/layout move under src/ - did also already with module builder intro
  • Get in use LogosResult as default return value for plugin interface.

Update

  • Now the PR contains correct and fixed version of module-builder that fixes the copy of dependent liblogosdelivery dynamic library to be copied correctly to /lib and will pack it to lgx.
  • added librln dependency of liblogosdelivery to the artifacts to be bundled.
  • generating module header / source stub code is also correct now.

@NagyZoltanPeter NagyZoltanPeter self-assigned this Feb 25, 2026
@NagyZoltanPeter NagyZoltanPeter force-pushed the chore-enhance-api-sequrity-and-data branch from 1bf42c8 to 5e8cda1 Compare February 26, 2026 13:58
@NagyZoltanPeter
creatNode securty enhancements. Prevent multi thread creatNode call, …
977c0e7 
…prevent multi ininitialization. Fix creatNode callback handling for fine resource handling
@NagyZoltanPeter
move sources under ./src
9b48a43
@NagyZoltanPeter NagyZoltanPeter force-pushed the chore-enhance-api-sequrity-and-data branch from 5e8cda1 to 9b48a43 Compare February 26, 2026 13:59
@NagyZoltanPeter NagyZoltanPeter changed the title Chore:enhance api sequrity and add health status event chore: createNode security hardening + source move to src Feb 26, 2026
Ivansete-status
Ivansete-status approved these changes Feb 26, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

Comment thread test/test_create_node_integration.cpp Outdated
Comment on lines +103 to +105
if (!hasLibpqDependency()) {
QSKIP("libpq dynamic library is not available; skipping logosdelivery integration test.");
}
Copy link
Copy Markdown
Collaborator

@Ivansete-status Ivansete-status Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add this in a tiny macro/template

@NagyZoltanPeter
Copy link
Copy Markdown
Collaborator Author

NagyZoltanPeter commented Apr 14, 2026

@iurimatias: I have merged you module builder pr and this PR is built on top of those changes.
Please help me out, with module builder expected requirements in order to build this module properly.
Currently I see that it does not builds logos-delivery -> liblogosdelivery.dylib and provide the include for building the module itself.

What do we do wrong here?

darshankabariya
darshankabariya approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown

@darshankabariya darshankabariya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@iurimatias
Copy link
Copy Markdown
Member

iurimatias commented Apr 14, 2026

@iurimatias: I have merged you module builder pr and this PR is built on top of those changes. Please help me out, with module builder expected requirements in order to build this module properly. Currently I see that it does not builds logos-delivery -> liblogosdelivery.dylib and provide the include for building the module itself.

What do we do wrong here?

@iurimatias: I have merged you module builder pr and this PR is built on top of those changes. Please help me out, with module builder expected requirements in order to build this module properly. Currently I see that it does not builds logos-delivery -> liblogosdelivery.dylib and provide the include for building the module itself.

What do we do wrong here?

will do a fix for this

@NagyZoltanPeter NagyZoltanPeter merged commit bc03087 into master Apr 15, 2026
@NagyZoltanPeter
Copy link
Copy Markdown
Collaborator Author

NagyZoltanPeter commented Apr 15, 2026

@iurimatias As this PR is merged now, please rebase your one in order to get to the same page.
This PR fixes all previous build issues, it includes liblogosdelivery + librln to the bundle.

@NagyZoltanPeter NagyZoltanPeter mentioned this pull request Apr 15, 2026
Open
10 tasks
@NagyZoltanPeter
Copy link
Copy Markdown
Collaborator Author

NagyZoltanPeter commented Apr 21, 2026

Issue: #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcecin fcecin fcecin approved these changes

@darshankabariya darshankabariya darshankabariya approved these changes

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@iurimatias iurimatias Awaiting requested review from iurimatias

@igor-sirotin igor-sirotin Awaiting requested review from igor-sirotin

Assignees

@NagyZoltanPeter NagyZoltanPeter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NagyZoltanPeter @iurimatias @fcecin @darshankabariya @Ivansete-status