Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable xfail tests in adjust-calling-conventions.mlir due to LLVM Bump #3983

Open
vivekkhandelwal1 opened this issue Jan 27, 2025 · 2 comments · May be fixed by #4034
Open

Enable xfail tests in adjust-calling-conventions.mlir due to LLVM Bump #3983

vivekkhandelwal1 opened this issue Jan 27, 2025 · 2 comments · May be fixed by #4034
Assignees
@vivekkhandelwal1

Comments

@vivekkhandelwal1
Copy link
Collaborator

Due to the changes in upstream LLVM Project, changes have to be made to the AdjustCallingConventions pass still the pass is not fully functional as of now. Hence, some of the tests related to this pass are disabled here: #3982.

This issue is to keep track of the progress made on fixing this issue.
@vivekkhandelwal1 vivekkhandelwal1 self-assigned this Jan 27, 2025
@vivekkhandelwal1 vivekkhandelwal1 mentioned this issue Jan 27, 2025
Merged
vivekkhandelwal1 added a commit that referenced this issue Jan 28, 2025
@vivekkhandelwal1 @justin-ngo-arm
Integrate LLVM at e2402615a5a76d46a433dfcc1de10b38a1263c9d (#3982)
1225073 
Update LLVM to

llvm/llvm-project@e240261
Update StableHlo to

openxla/stablehlo@8cd9444

Updates API calls from:
1. `applyPatternsAndFoldGreedily` -> `applyPatternsGreedily`
2. `applyOpPatternsAndFold` -> `applyOpPatternsGreedily`

This commit also inlines the `BufferizeTypeConverter` in Torch-MLIR
which has been removed from the LLVM project here:

llvm/llvm-project@2ff2e87.

This commit also updates the `AdjustCallingConventions` pass in order to
align with the changes made for `TypeConverter` upstream. Some of the
tests from the `adjust-calling-conventions.mlir` are disabled for the
time being since they are not supported even after making changes in the
pass. We will enable them once the `AdjustCallingConventions` pass is
fully functional in a seperate PR. The fix will be tracked by
#3983.


TOSA Updates Summary:

Update Torch to TOSA legalizations with TOSA 1.0 ops' forms from LLVM
hash 64edde66. Changes include:

TOSA Pad op's new shape requirement
TOSA Convolution ops' new acc_type
TOSA Tile with multiples as a !tosa.shape input

---------

Signed-off-by: Vivek Khandelwal <[email protected]>
Co-authored-by: Justin Ngo <[email protected]>
@AaronStGeorge
Copy link
Collaborator

Hi @vivekkhandelwal1, we're hitting the same error as the disabled tests internally at Cruise. Do you have a fix ready? I'm happy to help out too! I'm aaronstgeorge on discord if you would like to chat :)

@AaronStGeorge AaronStGeorge linked a pull request Feb 20, 2025 that will close this issue
Open
@vivekkhandelwal1
Copy link
Collaborator Author

Hi @vivekkhandelwal1, we're hitting the same error as the disabled tests internally at Cruise. Do you have a fix ready? I'm happy to help out too! I'm aaronstgeorge on discord if you would like to chat :)

Hi @AaronStGeorge, thanks for reaching out. It seems you've a fix ready. Or, you still need any help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivekkhandelwal1 vivekkhandelwal1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable torch-adjust-calling-conventions tests AaronStGeorge/torch-mlir
2 participants
@AaronStGeorge @vivekkhandelwal1