Add a build/test workflow for Windows #3985

Activity

1. sahas3 commented on Feb 19, 2025

   

   sahas3

   on Feb 19, 2025

   Last edited by sahas3

   Member

   More actions

   I gave this a shot by reusing https://github.com/llvm/torch-mlir/blob/main/build_tools/python_deploy/build_windows_ci.sh which is used for building the windows wheels in torch-mlir-release repo. The build worked fine but testing fails because signal.SIGALRM (used for timeout handling -- not much familiar with this piece of testing code) is not available for Windows. That's a different problem to solve to enable testing on Windows even outside of the CI workflow, so will create a separate issue for that. However, is there a benefit to still add a build only CI for now?
2. ScottTodd commented on Feb 19, 2025

   

   ScottTodd

   on Feb 19, 2025

   MemberAuthor

   More actions

   However, is there a benefit to still add a build only CI for now?

   I would say yes. I would expect most platform differences to come into play at build time, not test time. Could also run a subset of tests (e.g. unit tests, but not integration tests).

   ---

   As for that failure due to

   torch-mlir/projects/pt1/python/torch_mlir_e2e_test/framework.py

   Lines 310 to 323 in a265d28

   	class timeout:
   	def __init__(self, seconds=1, error_message="Timeout"):
   	self.seconds = seconds
   	self.error_message = error_message
   	def handle_timeout(self, signum, frame):
   	raise TimeoutError(self.error_message)
   	def __enter__(self):
   	signal.signal(signal.SIGALRM, self.handle_timeout)
   	signal.alarm(self.seconds)
   	def __exit__(self, type, value, traceback):
   	signal.alarm(0)

   I'd suggest (to whoever looks into it) checking out https://pypi.org/project/pytest-timeout/. Ideally just use that plugin with pytest and not implement something custom. Short of that, see the notes about timeout methods and portability.
3. sahas3

   added a commit that references this issue on Mar 9, 2025

   Add Windows build workflow in the CI. (#4041)

   ...

   daad812