-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a build/test workflow for Windows #3985
Comments
I gave this a shot by reusing https://github.com/llvm/torch-mlir/blob/main/build_tools/python_deploy/build_windows_ci.sh which is used for building the windows wheels in torch-mlir-release repo. The build worked fine but testing fails because |
I would say yes. I would expect most platform differences to come into play at build time, not test time. Could also run a subset of tests (e.g. unit tests, but not integration tests). As for that failure due to torch-mlir/projects/pt1/python/torch_mlir_e2e_test/framework.py Lines 310 to 323 in a265d28
I'd suggest (to whoever looks into it) checking out https://pypi.org/project/pytest-timeout/. Ideally just use that plugin with pytest and not implement something custom. Short of that, see the notes about timeout methods and portability. |
We've seen several downstream build breaks from torch-mlir due to missing test coverage. Having at least a nightly CI build using GitHub-hosted runners would provide earlier signal for build issues.
Existing workflows
Expanding to new platforms
I see scripts used by ci.yml that could be forked or generalized:
A workflow could also be added that runs commands directly. I've been moving https://github.com/iree-org/iree (a downstream user of torch-mlir) away from such scripts, instead opting to make the build system work better out of the box using default options, with things like ccache and the choice of compiler (e.g. gcc/clang) delegated to the user's choice or a github action that configures environment variables.
The text was updated successfully, but these errors were encountered: