refactor(ONNX): renames getValueList helper to createScalarSublist

- Before:
  - "get": implies retrieval of some private property
  - "Value": restatement of the return type `Value`
  - "List": assumed result of casting the returned instance
- After:
  - "create": contextualizes the need to pass in `rewriter`
  - "Scalar": contextualizes the opaque return type
  - "Sublist": the relationship between the first parameter and the returned result

Author: bjacobgordon

lib/Conversion/TorchOnnxToTorch/DefaultDomainQtoZ.cpp

@@ -207,7 +207,7 @@ Value createScalarAs(
 }
 
 template <typename SomeTorchScalarType>
-Value getValueList(
+Value createScalarSublist(
     /*                      at */ Location givenLoc,
     /*                    from */ Value given1DTensor,
     /* throughBackStartingWith */ int64_t givenIndex,
@@ -2825,13 +2825,13 @@ void mlir::torch::onnx_c::populateDefaultDomainQtoZ(
 
         if (operands.size() < 4) {
           Value scaleOperand = operands[2];
-          scalesValueList = getValueList<Torch::FloatType>(
+          scalesValueList = createScalarSublist<Torch::FloatType>(
               binder.getLoc(), scaleOperand, foremostSupportedDim, rewriter);
           sizesValueList = noneVal;
         } else {
           Value sizeOperand = operands[3];
           scalesValueList = noneVal;
-          sizesValueList = getValueList<Torch::IntType>(
+          sizesValueList = createScalarSublist<Torch::IntType>(
               binder.getLoc(), sizeOperand, foremostSupportedDim, rewriter);
         }
         if (isa<Torch::NoneType>(scalesValueList.getType()) &&
@@ -3356,7 +3356,7 @@ void mlir::torch::onnx_c::populateDefaultDomainQtoZ(
               binder.op, "supports upto 3d upsampling only");
 
         auto foremostSupportedDim = TorchImageTensor::heightDim;
-        Value scalesValueList = getValueList<Torch::FloatType>(
+        Value scalesValueList = createScalarSublist<Torch::FloatType>(
             binder.getLoc(), scales, foremostSupportedDim, rewriter);
         if (mode == "linear") {
           if (resultRank == 4)