[clang] Deduplicate FinishTemplateArgumentDeduction helper function in SemaTemplateDeduction.cpp.

[hokein]

In SemaTemplateDeduction.cpp, we have two duplicated versions of FinishTemplateArgumentDeduction. And after #89358, we have three duplications.

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: Haojian Wu (hokein)

In `SemaTemplateDeduction.cpp`, we have two duplicated versions of [`FinishTemplateArgumentDeduction`](https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaTemplateDeduction.cpp#L3192). And after #89358, we have three duplications.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Haojian Wu (hokein)

In `SemaTemplateDeduction.cpp`, we have two duplicated versions of [`FinishTemplateArgumentDeduction`](https://github.com/llvm/llvm-project/blob/main/clang/lib/Sema/SemaTemplateDeduction.cpp#L3192). And after #89358, we have three duplications.

[Rajveer100]

@hokein
The refactoring would decrease the overall lines of code, but don't you think it would be a little clumsy to make it a single function, let me know what's your approach?

[akielaries]

If this is still something that needs to be tackled I can open a PR for it

[cor3ntin]

If this is still something that needs to be tackled I can open a PR for it

Yes! Thanks in advance

[akielaries]

Spending some time to work on this today/this upcoming week. I'm curious if keeping the same 3 overload functions and split out common logic to some util functions would be ideal? Looks like the parameters of all 3 are slightly different but all have some similar underlying logic

[rajkumarananthu]

Hi @akielaries are you working on this or can I work on this? Can you please confirm..

Thanks
Rajkumar Ananthu.

[akielaries]

@rajkumarananthu All yours!

[the-slow-one]

@hokein I guess we still care about this issue! No?