Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a lot of Ref location outside file message print out when dumping a HTML report #59421

Open
hokein opened this issue Dec 9, 2022 · 1 comment

Comments

@hokein
Copy link
Collaborator

hokein commented Dec 9, 2022

running clang-include-cleaner to dump html report on SemaExpr.cpp, it prints a lot of the error messages because of the def include pattern is used in the main file.

Ref location outside file! clang::BuiltinType at /workspace/llvm-project/clang/include/clang/AST/BuiltinTypes.def:246:1 <Spelling=llvm-project/clang/lib/Sema/SemaExpr.cpp:21073:44>

This is a FIXME in https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/include-cleaner/lib/HTMLReport.cpp#L224. Options:

  • remove the llvm::errs statement directly
  • use the spelling loc as the ref loc (this implies that a lot of refs are bind to the same location, which doesn't seem useful)
@llvmbot
Copy link
Member

llvmbot commented Dec 9, 2022

@llvm/issue-subscribers-clang-include-cleaner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants