Skip to content

P2944R3: Update comparisons for reference_wrapper #138233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Zingam opened this issue May 2, 2025 · 0 comments · May be fixed by #139368
Open

P2944R3: Update comparisons for reference_wrapper #138233

Zingam opened this issue May 2, 2025 · 0 comments · May be fixed by #139368
Labels
c++26 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Comments

@Zingam
Copy link
Contributor

Zingam commented May 2, 2025

Current implementation uses __boolean_testable as per comments it should be updated to use __is_core_convertible as per: #135759 (comment)
@Zingam Zingam added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. c++26 labels May 2, 2025
H-G-Hristov added a commit to H-G-Hristov/llvm-project that referenced this issue May 10, 2025
@H-G-Hristov
[libc++] P2944R3: Constrained comparisions - the optional and `refe…
754c897 
…rence_wrapper`

Partially implements [P2944R3](https://wg21.link/P2944R3), which adds constrained comparisons to `optional` and `reference_wrapper`.

Generalizes the test helpers in `test_comparisons.h` to support constrained comparisons.

- [refwrap.comparisons](https://wg21.link/refwrap.comparisons)
- [optional.relops](https://wg21.link/optional.relops)
- [https://wg21.link/optional.comp.with.t](https://wg21.link/optional.comp.with.t)

Closes llvm#136767
Closes llvm#138233

Relates to: llvm#135759
@H-G-Hristov H-G-Hristov linked a pull request May 10, 2025 that will close this issue
Open
H-G-Hristov added a commit to H-G-Hristov/llvm-project that referenced this issue May 10, 2025
@H-G-Hristov
[libc++] P2944R3: Constrained comparisions - the optional and `refe…
9536509 
…rence_wrapper`

Partially implements [P2944R3](https://wg21.link/P2944R3), which adds constrained comparisons to `optional` and `reference_wrapper`.

Generalizes the test helpers in `test_comparisons.h` to support constrained comparisons.

- [refwrap.comparisons](https://wg21.link/refwrap.comparisons)
- [optional.relops](https://wg21.link/optional.relops)
- [https://wg21.link/optional.comp.with.t](https://wg21.link/optional.comp.with.t)

Closes llvm#136767
Closes llvm#138233

Relates to: llvm#135759
H-G-Hristov added a commit to H-G-Hristov/llvm-project that referenced this issue May 10, 2025
@H-G-Hristov
[libc++] P2944R3: Constrained comparisions - the optional and `refe…
61e16a8 
…rence_wrapper`

Partially implements [P2944R3](https://wg21.link/P2944R3), which adds constrained comparisons to `optional` and `reference_wrapper`.

Generalizes the test helpers in `test_comparisons.h` to support constrained comparisons.

- [refwrap.comparisons](https://wg21.link/refwrap.comparisons)
- [optional.relops](https://wg21.link/optional.relops)
- [https://wg21.link/optional.comp.with.t](https://wg21.link/optional.comp.with.t)

Closes llvm#136767
Closes llvm#138233

Relates to: llvm#135759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++26 libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc++] P2944R3: Constrained comparisions - optional and reference_wrapper H-G-Hristov/llvm-project
3 participants
@Zingam @EugeneZelenko @llvmbot