Skip to content

[Polly] Update ScopInliner for NPM #125427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 17, 2025
Merged

[Polly] Update ScopInliner for NPM #125427

merged 8 commits into from
Oct 17, 2025

Conversation

Meinersbur
Copy link
Member

@Meinersbur Meinersbur commented Feb 2, 2025 •
edited
Loading

Rename the LPM ScopInliner pass to ScopInlinerWrapperPass and add a new class ScopInliner for the NPM.

@Meinersbur Meinersbur marked this pull request as ready for review February 3, 2025 00:47
@Meinersbur Meinersbur requested a review from kartcq February 3, 2025 14:36
@Meinersbur Meinersbur mentioned this pull request Feb 3, 2025
Open
@Meinersbur Meinersbur marked this pull request as draft May 17, 2025 22:25
@Meinersbur Meinersbur marked this pull request as ready for review October 16, 2025 08:35
Base automatically changed from users/meinersbur/polly_remove-PolyhedralInfo to main October 16, 2025 09:11
@Meinersbur Meinersbur enabled auto-merge (squash) October 17, 2025 07:32
@Meinersbur Meinersbur merged commit 0b9a7b8 into main Oct 17, 2025
11 checks passed
@Meinersbur Meinersbur deleted the users/meinersbur/polly_NPM-ScopInliner branch October 17, 2025 07:43
boomanaiden154 added a commit that referenced this pull request Oct 17, 2025
@boomanaiden154
Revert "[Polly] Update ScopInliner for NPM (#125427)"
a99e32b 
This reverts commit 0b9a7b8.

This is causing test failures under LLVM:
1. Other/pass-pipeline-parsing.ll

This broke premerge. This was notably not caught by premerge testing on
the original PR because the original PR only touches polly, and premerge
does not test LLVM when only polly is touched.
@boomanaiden154
Copy link
Contributor

I've reverted this for breaking a LLVM test. Premerge did not catch this because when only Polly is touched, check-llvm is not run. When relanding, please make sure to run check-llvm and check-polly locally beforehand.

@Meinersbur
Copy link
Member Author

Thanks for taking care for it. I did run it locally, but now found the problem only reproduces with LLVM_POLLY_LINK_INTO_TOOLS=ON. At the same time I found that the polly-* buildbots (which test all of these combinations) were lagging behind 3 days. GCE seems to restart them when they barely can get a build completed because of failed "integrity checks". Investigating both problems.

@boomanaiden154
Copy link
Contributor

LLVM_POLLY_LINK_INTO_TOOLS=ON

I was able to reproduce without this option being explicitly set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartcq kartcq Awaiting requested review from kartcq

@efriedma-quic efriedma-quic Awaiting requested review from efriedma-quic

@pfaffe pfaffe Awaiting requested review from pfaffe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Meinersbur @boomanaiden154