Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc][POSIX] generate sys/wait.h for aarch64 #125102

Open
nickdesaulniers opened this issue Jan 30, 2025 · 4 comments · May be fixed by #125171
Open

[libc][POSIX] generate sys/wait.h for aarch64 #125102

nickdesaulniers opened this issue Jan 30, 2025 · 4 comments · May be fixed by #125171
Labels
good first issue https://github.com/llvm/llvm-project/contribute libc

Comments

@nickdesaulniers
Copy link
Member

In order to make out unit tests hermetic for cross compilation, we need to implement waitpid from sys/wait.h for use in libc/test/UnitTest/ExecuteFunctionUnix.cpp.

@llvmbot
Copy link
Member

llvmbot commented Jan 30, 2025

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

In order to make out unit tests hermetic for cross compilation, we need to implement `waitpid` from sys/wait.h for use in libc/test/UnitTest/ExecuteFunctionUnix.cpp.

@nickdesaulniers
Copy link
Member Author

nickdesaulniers commented Jan 30, 2025

uh...what? We already have a waitpid (995105d). And it's being declared in our generated sys/wait.h...

It seems that our generated build_dir/libc/include/sys/wait.h is...empty...

libc.src.sys.wait.waitpid is a defined entrypoint in libc/config/linux/aarch64/entrypoints.txt

Ah! But libc.include.sys_wait is not in libc/config/linux/aarch64/headers.txt. Should be trivial to add it, if someone is looking for a softball.

@nickdesaulniers nickdesaulniers changed the title [libc][POSIX] provide waitpid from sys/wait.h [libc][POSIX] generate sys/wait.h for additional architectures Jan 30, 2025
@nickdesaulniers nickdesaulniers added the good first issue https://github.com/llvm/llvm-project/contribute label Jan 30, 2025
@nickdesaulniers nickdesaulniers changed the title [libc][POSIX] generate sys/wait.h for additional architectures [libc][POSIX] generate sys/wait.h for aarch64 Jan 30, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 30, 2025

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

@llvmbot
Copy link
Member

llvmbot commented Jan 30, 2025

@llvm/issue-subscribers-good-first-issue

Author: Nick Desaulniers (nickdesaulniers)

In order to make out unit tests hermetic for cross compilation, we need to implement `waitpid` from sys/wait.h for use in libc/test/UnitTest/ExecuteFunctionUnix.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue https://github.com/llvm/llvm-project/contribute libc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants