Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc][POSIX] provide WIFSIGNALED from <sys/wait.h> #124944

Closed
nickdesaulniers opened this issue Jan 29, 2025 · 3 comments · Fixed by #125572
Closed

[libc][POSIX] provide WIFSIGNALED from <sys/wait.h> #124944

nickdesaulniers opened this issue Jan 29, 2025 · 3 comments · Fixed by #125572
Assignees
@nickdesaulniers
Labels
libc

Comments

@nickdesaulniers
Copy link
Member

building llvm with llvm-libc fails with:

/llvm-project-main/llvm/lib/Support/Unix/Program.inc:497:14: error: use of undeclared identifier 'WIFSIGNALED'

we're missing this macro from POSIX
@llvmbot
Copy link
Member

llvmbot commented Jan 29, 2025

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

building llvm with llvm-libc fails with: ``` /llvm-project-main/llvm/lib/Support/Unix/Program.inc:497:14: error: use of undeclared identifier 'WIFSIGNALED' ``` we're missing this macro from POSIX

@nickdesaulniers
Copy link
Member Author

nickdesaulniers commented Jan 30, 2025 •
edited
Loading

We also need WIFEXITED, WEXITSTATUS, and WTERMSIG for #125092.

@nickdesaulniers
Copy link
Member Author

WIFEXITED, WEXITSTATUS, and WTERMSIG

e3638e8

The underlying issue for those 3 is #125102.

WIFSIGNALED

c9783d2 dropped this by accident...

@nickdesaulniers nickdesaulniers self-assigned this Feb 3, 2025
nickdesaulniers added a commit to nickdesaulniers/llvm-project that referenced this issue Feb 3, 2025
@nickdesaulniers
[libc][sys/wait][linux] add missing and clean up existing macros
02de82e 
This patch does a few things:
- replace macro definitions with an inclusion of the linux/wait.h kernel
  header.
  - WNOHANG
  - WUNTRACED
  - WEXITED
  - WCONTINUED
  - WSTOPPED
  - P_ALL
  - P_PID
  - P_PGID
  - P_PIDFD
- Add missing macro definitions mandated by POSIX. Some are needed to build
  LLVM.
  - WCOREDUMP
  - WIFCONTINUED
  - WIFSIGNALELD
  - WIFSTOPPED
  - WSTOPSIG
- Remove glibc style __W* macros.  Users should stick with the POSIX macros. We
  can re-add them if necessary.
  - __WEXITSTATUS
  - __WTERMSIG
  - __WIFEXITED
  - __WIFSIGNALED
  - __WIFSTOPPED
  - __WIFCONTINUED
  - __WCOREDUMP
  - __W_EXITCODE
  - __W_STOPCODE
  - __W_CONTINUED
  - __WCOREFLAG

Fixes: llvm#124944
@nickdesaulniers nickdesaulniers mentioned this issue Feb 3, 2025
Merged
Icohedron pushed a commit to Icohedron/llvm-project that referenced this issue Feb 11, 2025
@nickdesaulniers @Icohedron
[libc][sys/wait][linux] add missing and clean up existing macros (llv…
31b9d65 
…m#125572)

This patch does a few things:
- replace macro definitions with an inclusion of the linux/wait.h kernel
  header.
  - WNOHANG
  - WUNTRACED
  - WEXITED
  - WCONTINUED
  - WSTOPPED
  - P_ALL
  - P_PID
  - P_PGID
  - P_PIDFD
- Add missing macro definitions mandated by POSIX. Some are needed to
  build LLVM.
  - WCOREDUMP
  - WIFCONTINUED
  - WIFSIGNALELD
  - WIFSTOPPED
  - WSTOPSIG
- Remove glibc style __W* macros. Users should stick with the POSIX
  macros. We can re-add them if necessary.
  - __WEXITSTATUS
  - __WTERMSIG
  - __WIFEXITED
  - __WIFSIGNALED
  - __WIFSTOPPED
  - __WIFCONTINUED
  - __WCOREDUMP
  - __W_EXITCODE
  - __W_STOPCODE
  - __W_CONTINUED
  - __WCOREFLAG

Fixes: llvm#124944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickdesaulniers nickdesaulniers

Labels
libc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[libc][sys/wait][linux] add missing and clean up existing macros nickdesaulniers/llvm-project
2 participants
@nickdesaulniers @llvmbot