Revisit the llvm/test/ExecutionEngine/JITLink/x86-64/COFF_comdat_weak_plus_strong.s test

[hokein]

I discovered an error in this test, and fixed it in e576c5b.

However, this test doesn't seem to test anything -- I made some arbitrary changes (e.g. llvm-jitlink to llvm-not-valid on Line 9), the test was still passed. It is a little hard to understand the purpose of this test with the combination of XFAIL:* and not.

@sunho, you're the author of this test, can you take a look at this test?

[llvmbot]

@llvm/issue-subscribers-jitlink

Author: Haojian Wu (hokein)

I discovered an error in this test, and fixed it in https://github.com/llvm/llvm-project/commit/e576c5bed79f8a9528391756c8475cc3a6276adf.

However, this test doesn't seem to test anything -- I made some arbitrary changes (e.g. llvm-jitlink to llvm-not-valid on Line 9), the test was still passed. It is a little hard to understand the purpose of this test with the combination of XFAIL:* and not.

@sunho, you're the author of this test, can you take a look at this test?

[lhames]

@hokein It looks like this is a test for an expected error that is not produced yet:

FIXME: Comdat any + ordinary strong symbol should generate duplicate section error

So not llvm-jitlink ... is "This should fail with an error", and XFAIL: * is "but we're not producing the error yet".