Skip to content

Commit e0252c6

Browse files
committed
Address review comments
1 parent d09aabc commit e0252c6

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

lld/ELF/SyntheticSections.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,7 @@ void GotSection::writeTo(uint8_t *buf) {
745745
// If address diversity is set and the discriminator
746746
// is 0 then modifier = Place
747747
uint8_t *dest = buf + authEntry.offset;
748-
uint64_t key = authEntry.isSymbolFunc ? /*IA*/ 0b00 : /*DA*/ 0b10;
748+
uint64_t key = authEntry.isSymbolFunc ? /*IA=*/0b00 : /*DA=*/0b10;
749749
uint64_t addrDiversity = 1;
750750
write64(ctx, dest, (addrDiversity << 63) | (key << 60));
751751
}

lld/test/ELF/aarch64-got-relocations-pauth.s

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# RUN: ld.lld -shared a.o -o a.so
77

88
#--- ok.s
9-
109
# RUN: llvm-mc -filetype=obj -triple=aarch64 ok.s -o ok.o
1110

1211
# RUN: ld.lld ok.o a.so -pie -o external
@@ -79,10 +78,9 @@ _start:
7978
add x1, x1, :got_auth_lo12:zed
8079

8180
#--- err.s
82-
8381
# RUN: llvm-mc -filetype=obj -triple=aarch64 err.s -o err.o
8482

85-
# RUN: not ld.lld err.o a.so -pie -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR
83+
# RUN: not ld.lld err.o a.so -pie -o /dev/null 2>&1 | FileCheck %s --check-prefix=ERR --implicit-check-not=error:
8684

8785
# ERR: error: both AUTH and non-AUTH GOT entries for 'bar' requested, but only one type of GOT entry per symbol is supported
8886
# ERR-NEXT: >>> defined in a.so

0 commit comments

Comments
 (0)