[CIR][CIRGen] Add support for TBAA

Author: PikachuHyA

clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h

@@ -160,8 +160,9 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
     llvm_unreachable("Zero initializer for given type is NYI");
   }
 
-  mlir::Value createLoad(mlir::Location loc, mlir::Value ptr,
-                         bool isVolatile = false, uint64_t alignment = 0) {
+  mlir::cir::LoadOp createLoad(mlir::Location loc, mlir::Value ptr,
+                               bool isVolatile = false,
+                               uint64_t alignment = 0) {
     mlir::IntegerAttr intAttr;
     if (alignment)
       intAttr = mlir::IntegerAttr::get(
@@ -575,8 +576,7 @@ class CIRBaseBuilderTy : public mlir::OpBuilder {
         });
 
     if (last != block->rend())
-      return OpBuilder::InsertPoint(block,
-                                    ++mlir::Block::iterator(&*last));
+      return OpBuilder::InsertPoint(block, ++mlir::Block::iterator(&*last));
     return OpBuilder::InsertPoint(block, block->begin());
   };
 

clang/include/clang/CIR/MissingFeatures.h

@@ -58,6 +58,7 @@ struct MissingFeatures {
   // sanitizer related type check features
   static bool buildTypeCheck() { return false; }
   static bool tbaa() { return false; }
+  static bool tbaa_struct() { return false; }
   static bool cleanups() { return false; }
   static bool emitNullabilityCheck() { return false; }
   static bool ptrAuth() { return false; }

clang/lib/CIR/CodeGen/CIRGenAtomic.cpp

@@ -590,7 +590,7 @@ static void buildAtomicOp(CIRGenFunction &CGF, AtomicExpr *E, Address Dest,
   case AtomicExpr::AO__atomic_load:
   case AtomicExpr::AO__scoped_atomic_load_n:
   case AtomicExpr::AO__scoped_atomic_load: {
-    auto *load = builder.createLoad(loc, Ptr).getDefiningOp();
+    auto load = builder.createLoad(loc, Ptr);
     // FIXME(cir): add scope information.
     assert(!MissingFeatures::syncScopeID());
     load->setAttr("mem_order", orderAttr);
@@ -1468,8 +1468,7 @@ void CIRGenFunction::buildAtomicStore(RValue rvalue, LValue dest,
     if (IsVolatile)
       store.setIsVolatile(true);
 
-    // DecorateInstructionWithTBAA
-    assert(!MissingFeatures::tbaa());
+    CGM.decorateOperationWithTBAA(store, dest.getTBAAInfo());
     return;
   }
 

clang/lib/CIR/CodeGen/CIRGenBuilder.h

@@ -843,8 +843,8 @@ class CIRGenBuilderTy : public CIRBaseBuilderTy {
                    addr.getAlignment());
   }
 
-  mlir::Value createLoad(mlir::Location loc, Address addr,
-                         bool isVolatile = false) {
+  mlir::cir::LoadOp createLoad(mlir::Location loc, Address addr,
+                               bool isVolatile = false) {
     auto ptrTy =
         mlir::dyn_cast<mlir::cir::PointerType>(addr.getPointer().getType());
     if (addr.getElementType() != ptrTy.getPointee())

clang/lib/CIR/CodeGen/CIRGenClass.cpp

@@ -743,8 +743,14 @@ void CIRGenFunction::initializeVTablePointer(mlir::Location loc,
   assert(!MissingFeatures::addressSpace());
   VTableField = builder.createElementBitCast(loc, VTableField,
                                              VTableAddressPoint.getType());
-  builder.createStore(loc, VTableAddressPoint, VTableField);
-  assert(!MissingFeatures::tbaa());
+  auto storeOp = builder.createStore(loc, VTableAddressPoint, VTableField);
+  TBAAAccessInfo TBAAInfo =
+      CGM.getTBAAVTablePtrAccessInfo(VTableAddressPoint.getType());
+  CGM.decorateOperationWithTBAA(storeOp, TBAAInfo);
+  if (CGM.getCodeGenOpts().OptimizationLevel > 0 &&
+      CGM.getCodeGenOpts().StrictVTablePointers) {
+    assert(!MissingFeatures::createInvariantGroup());
+  }
 }
 
 void CIRGenFunction::initializeVTablePointers(mlir::Location loc,
@@ -1663,14 +1669,16 @@ mlir::Value CIRGenFunction::getVTablePtr(mlir::Location Loc, Address This,
 
 Address CIRGenFunction::buildCXXMemberDataPointerAddress(
     const Expr *E, Address base, mlir::Value memberPtr,
-    const MemberPointerType *memberPtrType, LValueBaseInfo *baseInfo) {
+    const MemberPointerType *memberPtrType, LValueBaseInfo *baseInfo,
+    TBAAAccessInfo *tbaaInfo) {
   assert(!MissingFeatures::cxxABI());
 
   auto op = builder.createGetIndirectMember(getLoc(E->getSourceRange()),
                                             base.getPointer(), memberPtr);
 
   QualType memberType = memberPtrType->getPointeeType();
-  CharUnits memberAlign = CGM.getNaturalTypeAlignment(memberType, baseInfo);
+  CharUnits memberAlign =
+      CGM.getNaturalTypeAlignment(memberType, baseInfo, tbaaInfo);
   memberAlign = CGM.getDynamicOffsetAlignment(
       base.getAlignment(), memberPtrType->getClass()->getAsCXXRecordDecl(),
       memberAlign);

clang/lib/CIR/CodeGen/CIRGenDecl.cpp

@@ -327,7 +327,7 @@ void CIRGenFunction::buildAutoVarInit(const AutoVarEmission &emission) {
   // its removal/optimization to the CIR lowering.
   if (!constant || isa<CXXTemporaryObjectExpr>(Init)) {
     initializeWhatIsTechnicallyUninitialized(Loc);
-    LValue lv = LValue::makeAddr(Loc, type, AlignmentSource::Decl);
+    LValue lv = makeAddrLValue(Loc, type);
     buildExprAsInit(Init, &D, lv);
     // In case lv has uses it means we indeed initialized something
     // out of it while trying to build the expression, mark it as such.