Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated call to atom.showSaveDialogSync #223

Open
sarangjo opened this issue Sep 21, 2018 · 2 comments
Open

Deprecated call to atom.showSaveDialogSync #223

sarangjo opened this issue Sep 21, 2018 · 2 comments

Comments

@sarangjo
Copy link
Contributor

sarangjo commented Sep 21, 2018

In Atom 1.30.0,

atom.showSaveDialogSync is deprecated and will be removed soon. Please, implement ::saveAs and ::getSaveDialogOptions instead for pane items or use Pane::saveItemAs for programmatic saving.

It would be good to update the codebase to change these calls!

@chipschipschips
Copy link

This is still an issue in Atom v1.38.0, ex-mode 0.18.0 (latest version).

atom.showSaveDialogSync is deprecated and will be removed soon. Please, implement ::saveAs and ::getSaveDialogOptions instead for pane items or use Pane::saveItemAs for programmatic saving.
AtomEnvironment.showSaveDialogSync - <embedded>:1:714236
Ex.write - /Users/chips/.atom/packages/ex-mode/lib/ex.coffee:348:25
Ex.w - /Users/chips/.atom/packages/ex-mode/lib/ex.coffee:373:19
<unknown> - /Users/chips/.atom/packages/ex-mode/lib/ex.coffee:3:59
Command.execute - /Users/chips/.atom/packages/ex-mode/lib/command.coffee:194:18
ExState.processOpStack - /Users/chips/.atom/packages/ex-mode/lib/ex-state.coffee:83:19

@rhinesj
Copy link

rhinesj commented Aug 5, 2020

Any plans to update ex-mode to address it? Any tips to disable the code that causes the deprecation warning without breaking much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants