Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmap usage of Top-50-Matplotlib-Visualizations is inaccurate #4

Open
yf-yang opened this issue Jan 20, 2019 · 1 comment
Open

cmap usage of Top-50-Matplotlib-Visualizations is inaccurate #4

yf-yang opened this issue Jan 20, 2019 · 1 comment

Comments

@yf-yang
Copy link

yf-yang commented Jan 20, 2019

Your modification (c -> cmap) of the original passage does remove the error, but it is not working as expected since cmap should not be used like that. For example, take a look at block [2] and print colors, you will find that last 2 color (for LHR, LHU) are exactly the same because the color map tab10 has only 10 colors. However, when you assign the tuple to the argument cmap, the argument doesn't recognize the float tuple. As a result, it is actually using a predefined color map.

@yf-yang
Copy link
Author

yf-yang commented Jan 20, 2019

Please review #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant