Skip to content

Inconsistent Firing of Disconnect Events Across Disconnection Paths #101

Closed as not planned

Description

@holofermes

Currently, the Disconnected event does not consistently fire across all disconnection paths. Specifically, when disconnection occurs through the DisconnectReceived callback, the event is not triggered at all.
Moreover the disconnect event should be fired with a DisconnectReason, currently it passes the room instead.

Proposed Solution:

  • Introduce a DisconnectDelegate that includes a DisconnectReason.
  • Update the Disconnected event to use this new delegate.
  • Ensure that the Disconnected event fires with a reason when disconnection occurs via the DisconnectReceived callback.

Looking at the enum for DisconnectReason I am not sure which one is the best in this case. I will make a PR using ClientInitiated, but this is arbitrary and can/should be revised as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    UnitybugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions