Commit 654410b
authored
Fix
Resolves #678
Follow-up of #679
I managed to reproduce the issue, steps:
- open example app on iPhone (non-sample buffer mode)
- join from e.g. macOS
- publish/unpublish camera track on mac
The diagnosis was correct - logs are coming via unsafe
`UIView`/`NSObject` territory, so main actor isolated props are listed
from bg threads. The last one was `isHidden`.
I also overrode the `description` string, just in case... for every
descendant of `NativeView` (that may inherit the description).
<img width="1483" alt="Screenshot 2025-04-22 at 10 40 14 AM"
src="https://github.com/user-attachments/assets/441d9bd8-6ecd-4b45-93b0-34517c6dab2b"
/>VideoView.isHidden crash (#681)1 parent 820c3d0 commit 654410b
File tree
3 files changed
+27
-2
lines changed- .nanpa
- Sources/LiveKit
- Extensions
- Views
3 files changed
+27
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
160 | 168 | | |
161 | 169 | | |
162 | 170 | | |
| |||
167 | 175 | | |
168 | 176 | | |
169 | 177 | | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
170 | 192 | | |
171 | 193 | | |
172 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
| 123 | + | |
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
127 | | - | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
128 | 130 | | |
129 | 131 | | |
130 | 132 | | |
| |||
0 commit comments