feat(rime): expand update_options to accept all TTS parameters #4095
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
@theomonnom something seems off with the Ruff formatter in the GitHub CI. I ran both the format and check commands locally and they passed, but the CI is still failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rime TTS plugin currently allows updates only for model and speaker values through the update_options method. This creates limitations for applications that need to adjust TTS behavior during runtime. Voice agents often modify temperature, speed, stability, latency settings, or other Rime specific parameters based on conversation context or user preference. Since these values cannot be changed without recreating the full TTS instance.