Revamped Upgrade Agent for Litmus 3.x.x #4740

kartikaysaxena · 2024-07-01T06:51:41Z

Proposed changes

Related #4632

Summarize your changes here to communicate with the maintainers and make sure to put the link of that issue

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Revamped Litmus Upgrade Agent for Litmus 3.x.x

Signed-off-by: Kartikay <[email protected]>

into upgrade-agent

Signed-off-by: Kartikay <[email protected]>

into upgrade-agent

Signed-off-by: Kartikay <[email protected]>

SarthakJain26

Please remove the commented code

Signed-off-by: Kartikay <[email protected]>

Saranya-jena · 2024-09-06T06:09:16Z

chaoscenter/upgrade-agents/control-plane/versions/upgrade-manager.go

+			NextVersion:    "",
+			VersionManager: v3_9_0.NewVersionManger(m.Logger, m.DBClient),
+		},
+		"4.0.0-beta8": {


We can remove this for now

Signed-off-by: Kartikay <[email protected]>

SarthakJain26

Great work @kartikaysaxena 🚀 , This is a great feature addition and will help the users in seamless upgrade of chaos center.

SarthakJain26 · 2024-09-06T06:12:38Z

chaoscenter/upgrade-agents/control-plane/CONTRIBUTING.MD

+1) If upgrade volume is huge, then transaction is not favorable.
+2) Split the upgrades into proprietary functions depending on their purpose and database/collection names.
+3) Use logging techniques as used in other versions to provide the user an insight of how the upgrades are being done.
+4) While using a transaction, make sure the session context is properly passed into the relevant mongo operations and related functions.


Script should be written in a way that even if run twice, should not affect the already updated documents.

SarthakJain26 · 2024-09-06T06:13:15Z

chaoscenter/upgrade-agents/control-plane/CONTRIBUTING.MD

+
+There are some other files not mentioned here.
+
+## **Upgrade to version 3.9.0**


Suggested change

## **Upgrade to version 3.9.0**

## **Example: Upgrade to version 3.9.0**

SarthakJain26 · 2024-09-06T06:16:53Z

chaoscenter/upgrade-agents/control-plane/versions/upgrade-manager.go

+	Beta  int
+}
+
+// Converts version from type string to type Version


Can you please add comment describing what this function will return for different inputs. For e.g 3.0.0-beta-10, 3.1.0, 3.1.1 etc

SarthakJain26 · 2024-09-13T06:43:56Z

chaoscenter/upgrade-agents/control-plane/versions/upgrade-manager.go

+			NextVersion:    "3.7.0",
+			VersionManager: nil,
+		},
+		"3.7.7-beta8": {


All these old versions where no upgrades are available can be removed from this map

SarthakJain26 · 2024-09-13T06:44:26Z

chaoscenter/upgrade-agents/control-plane/versions/upgrade-manager.go

+	}
+}
+
+func arrayToVersion(versionArray []int) string {


Please add a comment to describe what this function does

SarthakJain26 · 2024-09-13T06:48:55Z

chaoscenter/upgrade-agents/control-plane/versions/v0.0.0/upgrade.go

+
+func upgradeUsersCollection(logger *log.Logger, dbClient *mongo.Client, ctx context.Context) error {
+
+	logVersion := log.Fields{


Can you please follow this kind of logging here: https://github.com/litmuschaos/litmus/pull/4740/files#diff-c3dcc200129e5965fb7dc2655155eb285cfea424297940f911ffe1b6624b8316R62

SarthakJain26 · 2024-09-13T06:49:20Z

chaoscenter/upgrade-agents/control-plane/versions/v0.0.0/upgrade.go

+
+	environmentIDIndexExists := false
+
+	logVersion := log.Fields{


Can you please follow this kind of logging here: https://github.com/litmuschaos/litmus/pull/4740/files#diff-c3dcc200129e5965fb7dc2655155eb285cfea424297940f911ffe1b6624b8316R62

Please update in other places as well

SarthakJain26 · 2024-09-13T06:49:49Z

chaoscenter/upgrade-agents/control-plane/versions/v3.9.0/manager.go

+
+	defer session.EndSession(ctx)
+
+	logVersion := log.Fields{


Can you please follow this kind of logging here: https://github.com/litmuschaos/litmus/pull/4740/files#diff-c3dcc200129e5965fb7dc2655155eb285cfea424297940f911ffe1b6624b8316R62

Signed-off-by: Kartikay <[email protected]>

Saranya-jena · 2024-09-13T12:58:38Z

Awesome work @kartikaysaxena 🚀 ❤️

kartikaysaxena added 2 commits July 1, 2024 06:18

initialise upgrade-agent

6254e79

Signed-off-by: Kartikay <[email protected]>

dockerfile revert

b9945dc

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena mentioned this pull request Jul 1, 2024

Revamped Upgrade Agent for Litmus 3.x.x #4739

Closed

8 tasks

kartikaysaxena marked this pull request as draft July 1, 2024 10:27

kartikaysaxena added 4 commits July 5, 2024 00:15

Merge branch 'master' into upgrade-agent

760d748

go.mod

92a61ba

Signed-off-by: Kartikay <[email protected]>

Merge branch 'upgrade-agent' of https://github.com/kartikaysaxena/litmus

f49a980

into upgrade-agent

litmus-portal to chaoscenter

c176aa8

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena force-pushed the upgrade-agent branch 2 times, most recently from 2c4a19b to 09b3b07 Compare July 5, 2024 05:59

dummy versions and log

2db3496

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena force-pushed the upgrade-agent branch from 6e60bff to 2db3496 Compare July 5, 2024 06:01

CONTRIBUTING.md init

e8a3957

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena force-pushed the upgrade-agent branch from aaeaaa1 to e8a3957 Compare July 5, 2024 06:17

added checks while upgrading

d6c488a

Signed-off-by: Kartikay <[email protected]>

namkyu1999 assigned kartikaysaxena Jul 12, 2024

transactions

4edbcd2

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena force-pushed the upgrade-agent branch from 7f9949a to 4edbcd2 Compare July 15, 2024 00:20

kartikaysaxena added 2 commits July 18, 2024 13:03

transaction implemented in v3.4.0

f918ad5

Signed-off-by: Kartikay <[email protected]>

added upgrades for version 3.9.0

8e9e7c5

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena force-pushed the upgrade-agent branch from 9f75d4d to 8e9e7c5 Compare August 7, 2024 07:51

kartikaysaxena and others added 8 commits August 7, 2024 13:21

Merge branch 'master' into upgrade-agent

451c3a6

nit: gofmt

522c13f

Signed-off-by: Kartikay <[email protected]>

Merge branch 'upgrade-agent' of https://github.com/kartikaysaxena/litmus

ffb47d7

into upgrade-agent

Template for upgrades

671f0eb

Signed-off-by: Kartikay <[email protected]>

refactoring and dumping dummy versions

d10a76d

Signed-off-by: Kartikay <[email protected]>

Merge branch 'master' into upgrade-agent

f8b195d

gofmt

8934be3

Signed-off-by: Kartikay <[email protected]>

best practices

c5f56de

Signed-off-by: Kartikay <[email protected]>

SarthakJain26 reviewed Aug 16, 2024

View reviewed changes

kartikaysaxena added 2 commits August 16, 2024 23:01

removed commented code

73a4b09

Signed-off-by: Kartikay <[email protected]>

added flowchart

0379d74

Signed-off-by: Kartikay <[email protected]>

Saranya-jena marked this pull request as ready for review September 6, 2024 06:04

Merge branch 'master' into upgrade-agent

d7c0412

Saranya-jena reviewed Sep 6, 2024

View reviewed changes

kartikaysaxena and others added 2 commits September 6, 2024 14:40

removed dummy version from map

d1c0368

Signed-off-by: Kartikay <[email protected]>

Merge branch 'master' into upgrade-agent

c03966c

Saranya-jena approved these changes Sep 13, 2024

View reviewed changes

SarthakJain26 approved these changes Sep 13, 2024

View reviewed changes

refactor: better logs and comments

76ca831

Signed-off-by: Kartikay <[email protected]>

kartikaysaxena requested a review from SarthakJain26 September 13, 2024 09:09

Saranya-jena merged commit 41da06a into litmuschaos:master Sep 13, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revamped Upgrade Agent for Litmus 3.x.x #4740

Revamped Upgrade Agent for Litmus 3.x.x #4740

kartikaysaxena commented Jul 1, 2024

SarthakJain26 left a comment

Saranya-jena Sep 6, 2024

SarthakJain26 left a comment

SarthakJain26 Sep 6, 2024

SarthakJain26 Sep 6, 2024

SarthakJain26 Sep 6, 2024

SarthakJain26 Sep 13, 2024

SarthakJain26 Sep 13, 2024

SarthakJain26 Sep 13, 2024

SarthakJain26 Sep 13, 2024

SarthakJain26 Sep 13, 2024

Saranya-jena commented Sep 13, 2024


		There are some other files not mentioned here.

		## Upgrade to version 3.9.0

	## Upgrade to version 3.9.0
	## Example: Upgrade to version 3.9.0


		func upgradeUsersCollection(logger log.Logger, dbClient mongo.Client, ctx context.Context) error {

		logVersion := log.Fields{

Revamped Upgrade Agent for Litmus 3.x.x #4740

Revamped Upgrade Agent for Litmus 3.x.x #4740

Conversation

kartikaysaxena commented Jul 1, 2024

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

SarthakJain26 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SarthakJain26 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Saranya-jena commented Sep 13, 2024